refactor(chat): remove orphaned PersistentMemoryModal dead code - #292
Open
sebbsssss wants to merge 1 commit into
Open
refactor(chat): remove orphaned PersistentMemoryModal dead code#292sebbsssss wants to merge 1 commit into
sebbsssss wants to merge 1 commit into
Conversation
PersistentMemoryModal was a half-finished "permanent preferences" UI that was never wired into the app: never imported or rendered, no barrel re-export, no test, and no save-side (the `persistent-memory-changed` event it references has no external dispatcher). It also depended on a `PersistentMemory` type and `listPersistentMemories`/`deletePersistentMemory` ChatAPI methods that don't exist anywhere in the repo, and there is no backend endpoint for the feature. It was introduced incidentally in 87b728c ("chore: update gitignore as file is not pushed"). Because it referenced non-existent symbols, it produced 3 errors under `apps/chat` `tsc -b`. Removing it clears all three. The only remaining chat typecheck error is the pre-existing, unrelated main.tsx Solana RPC type error, left untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
apps/chat/src/components/PersistentMemoryModal.tsx— a half-finished "permanent preferences" component that was never wired into the app and was failing the chat app'stsc -b.Why it's dead code
apps/chat(only its own definition appeared in a repo-wide search). No barrel re-export, no lazy import, no test.persistent-memory-changedevent and references "whenever a suggestion card saves one," but no such dispatcher or suggestion card exists.PersistentMemorytype andapi.listPersistentMemories()/api.deletePersistentMemory()ChatAPI methods. There is also no backend endpoint for the feature.chore: update gitignore as file is not pushed).Effect on typecheck
The component referenced non-existent types/methods, producing 3 errors under
cd apps/chat && tsc -b::5import ofPersistentMemoryfrom../lib/types(not exported):23api.listPersistentMemories()(no such method):49api.deletePersistentMemory()(no such method)Deleting the file clears all three. Verified locally — the only remaining
apps/chattypecheck error afterward is the pre-existing, unrelatedmain.tsx(40,11)Solana RPC type error, which is left untouched (out of scope).Test plan
cd apps/chat && tsc -bno longer reports the 3PersistentMemoryModal.tsxerrorsPersistentMemoryModal,listPersistentMemories,deletePersistentMemory, or thePersistentMemorytype🤖 Generated with Claude Code