fix(chat): clear 4 pre-existing TypeScript errors so tsc -b is green - #277
Open
sebbsssss wants to merge 1 commit into
Open
fix(chat): clear 4 pre-existing TypeScript errors so tsc -b is green#277sebbsssss wants to merge 1 commit into
tsc -b is green#277sebbsssss wants to merge 1 commit into
Conversation
Remove orphaned PersistentMemoryModal.tsx and reconcile the @solana/kit RPC types in main.tsx. Both are type-only / dead-code changes with no runtime behavior change; the deploy already builds chat with vite only, so production was unaffected. PersistentMemoryModal: the persistent-memory feature (PR #81) was reverted in 7d26a7f, deleting the server route, the PersistentMemory type, and the listPersistentMemories/deletePersistentMemory ChatAPI methods. Commit 87b728c re-added only the modal component as a new file. It was imported nowhere and called a deleted backend route, so it was dead code; remove it rather than revive reverted functionality. main.tsx: createSolanaRpc(url: string) widens to a union including Rpc<SolanaRpcApiForAllClusters> (no requestAirdrop), while Privy's solana.rpcs config field is typed Rpc<SolanaRpcApi>. Both resolve the same @solana/kit 6.5.0, so assert the precise type at the boundary. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clears the 4 pre-existing TypeScript errors in
apps/chatsopnpm -C apps/chat exec tsc -b(and thebuildscript,tsc -b && vite build) is green again.These errors did not block production: the Docker deploy builds chat with
vite buildonly (esbuild, ignores type errors). But they made the localbuildscript red and masked real drift.Changes
Removed
apps/chat/src/components/PersistentMemoryModal.tsx(dead code). Fixes errors 1-3. The persistent-memory feature (PR #81) was reverted in7d26a7f5, deleting the server route (persistent-memory.routes.ts), thePersistentMemorytype, and thelistPersistentMemories/deletePersistentMemoryChatAPI methods. Commit87b728c8later re-added only the modal component as a new file (the old unanchoredchat/gitignore glob had been swallowing it underapps/chat/). It was imported nowhere and called a deleted backend route, so removing the orphan is correct rather than reviving reverted functionality.Reconciled
@solana/kitRPC types inmain.tsx. Fixes error 4.createSolanaRpc(url: string)widens to a union that includesRpc<SolanaRpcApiForAllClusters>(norequestAirdrop), while Privy'ssolana.rpcsconfig field is typedRpc<SolanaRpcApi>. Chat and Privy 3.18 resolve the same@solana/kit@6.5.0, so I assert the precise type Privy expects at the boundary. The cast is honest: at runtimecreateSolanaRpcproduces a full RPC; only TS is conservative about the non-literalstringURL.No runtime behavior change
Type-only edits plus dead-code removal.
Verification
pnpm -C apps/chat exec tsc -b --forceexits 0pnpm -C apps/chat build(tsc -b && vite build) builds cleanpnpm -C apps/chat exec vitest run2/2 passingpnpm-lock.yamluntouched🤖 Generated with Claude Code