Closed
Conversation
Indanz
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Can you configure git to have the correct author information and then do a git commit --amend -s && git push --force to add a sign-off?
And add a descriptive body text that explains why the change was made. Doesn't need to be elaborate.
E.g. change the title (first line) to "Fix runtime error" and use "See seL4/sel4test#152" as description.
Contributor
|
Thanks for doing this! |
Contributor
Author
|
Sorry it created another one for some reason. But not the other one in sel4test. Maybe close this one? |
Contributor
|
No problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See seL4/sel4test#152