Extract kernel object sizes from headers#456
Open
Ivan-Velickovic wants to merge 2 commits intomainfrom
Open
Conversation
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
object_sizes_from_kernel
branch
2 times, most recently
from
6aa3fc8 to
7ee449d
Compare
Many of these constants are architecture-dependent, but also slightly differ depending on how the kernel is configured. Rather than reproducing all the special combinations of kernel configurations that affect object size in the tool itself, just read from the source of truth. This should prevent bugs such as 7323d07. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
object_sizes_from_kernel
branch
from
7ee449d to
113fc40
Compare
|
These sizes are exported as defines in libsel4/sel4_arch_include/*/sel4/sel4_arch/constants.h, but not in a usable format. Feel free to open a PR in seL4 to export this information properly instead of adding hacks like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Addresses #378, but ideally this would be an output of the kernel build itself since it is useful outside of Microkit.