Skip to content

Test IPv6 and dual-stack entrypoints - #71

Merged
dkropachev merged 1 commit into
mainfrom
dk/driver-823-ipv6-dual-stack
Aug 6, 2026
Merged

Test IPv6 and dual-stack entrypoints#71
dkropachev merged 1 commit into
mainfrom
dk/driver-823-ipv6-dual-stack

Conversation

@dkropachev

@dkropachev dkropachev commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Jira: DRIVER-823

Cover IPv6 and dual-stack entrypoint behavior in the Node transport:

  • exercise discovery and DynamoDB routing through a literal IPv6 seed
  • cover deterministic A-only and AAAA-only DNS entrypoints
  • cover failed-AAAA-to-A and failed-A-to-AAAA fallback
  • verify an all-unavailable dual-stack endpoint returns promptly and preserves the configured seed
  • assert IPv6 URL and Host header bracket formatting

The existing implementation already preserves DNS hostnames, replaces seeds with learned nodes after discovery, and retains configured seeds as discovery recovery candidates.

Verification: npm run verify (62 tests passed).

Copilot AI balanced review requested due to automatic review settings August 6, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Timing and fresh-connection fallback behavior are not fully verified.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Adds Node transport coverage for IPv6 and dual-stack entrypoints.

Changes:

  • Tests IPv6 discovery, routing, URL, and Host formatting.
  • Tests DNS family selection, fallback, and seed retention.
File summaries
File Description
test/discovery.test.ts Adds IPv6 and dual-stack transport tests and DNS lookup helper.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread test/discovery.test.ts
Comment thread test/discovery.test.ts Outdated
Copilot AI review requested due to automatic review settings August 6, 2026 14:38
@dkropachev
dkropachev force-pushed the dk/driver-823-ipv6-dual-stack branch from 790b5b0 to dab0f07 Compare August 6, 2026 14:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The focused test additions correctly cover the described transport behavior without production-code risk.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

@dkropachev
dkropachev merged commit d04e451 into main Aug 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants