Test IPv6 and dual-stack entrypoints - #71
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Timing and fresh-connection fallback behavior are not fully verified.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds Node transport coverage for IPv6 and dual-stack entrypoints.
Changes:
- Tests IPv6 discovery, routing, URL, and Host formatting.
- Tests DNS family selection, fallback, and seed retention.
File summaries
| File | Description |
|---|---|
test/discovery.test.ts |
Adds IPv6 and dual-stack transport tests and DNS lookup helper. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
790b5b0 to
dab0f07
Compare
There was a problem hiding this comment.
🟢 Ready to approve
The focused test additions correctly cover the described transport behavior without production-code risk.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Jira: DRIVER-823
Cover IPv6 and dual-stack entrypoint behavior in the Node transport:
The existing implementation already preserves DNS hostnames, replaces seeds with learned nodes after discovery, and retains configured seeds as discovery recovery candidates.
Verification:
npm run verify(62 tests passed).