Skip to content

DiagVI tutorials#508

Open
michelta00 wants to merge 19 commits intoscverse:mainfrom
quadbio:diagvi-tutorials
Open

DiagVI tutorials#508
michelta00 wants to merge 19 commits intoscverse:mainfrom
quadbio:diagvi-tutorials

Conversation

@michelta00
Copy link

@michelta00 michelta00 commented Feb 21, 2026

Formatting

  • My tutorial has only one top-level (#) header

Reproducibility

  • My tutorial works on Google Colab
  • My tutorial sets scvi.settings.seed = 0 at the beginning of the notebook
  • My tutorial has been run and includes outputs (e.g. plots, tables)

Other

  • Counts and normalized data should co-exist in the datasets, see the API overview for an example
  • For scRNA-seq data, normalization should be counts per median library size and then log1p transformed -- if not, a reason should be given

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michelta00 michelta00 marked this pull request as draft February 21, 2026 17:47
@michelta00 michelta00 marked this pull request as ready for review February 22, 2026 11:33
Copy link
Contributor

@ori-kron-wis ori-kron-wis Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things:

  1. I wouldn't commit with warnings.filterwarnings("ignore")
  2. See other comments from the scvi-tools diagvi PR. e.g : compute_foscttm into a different location
  3. Add convergence curves
  4. Validate with the most recent scvi-tools/scib-metrics versions (from main branch)
  5. Validate both CPU/GPU runs (even a few epochs to see it works logically)
  6. Perhaps we want to compare to TotalVI and TotalANVI?. Both of them are multimodal for RNA and Protein data

@review-notebook-app
Copy link

review-notebook-app bot commented Mar 24, 2026

View / edit / reply to this conversation on ReviewNB

ori-kron-wis commented on 2026-03-24T13:27:43Z
----------------------------------------------------------------

Perhaps we want to compare to TotalVI and TotalANVI?. both of them multimodal for RNA and Protein data


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants