Sort tutorials by the registry's order key - #264
Merged
Conversation
Every tutorial in the registry carries an order value and the schema documents it as "lower numbers mean earlier", but the listing rendered them in whatever order the JSON happened to be in. Getting started with AnnData was showing up last under Data structures, and Preprocessing, clustering and cell-type annotation last under scRNA-seq. Tutorials without an order key sort last, and equal values keep their registry order. Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
✅ Deploy Preview for jade-cajeta-1bcca0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107.
The tutorial registry already has an optional
orderkey on every tutorial ("lower numbers mean earlier"), but the learn page ignored it and rendered whatever order the JSON happened to be in, so "Getting started with AnnData" showed up last under Data structures. The listing now sorts by it, with unordered tutorials last and equal values keeping registry order.