chore(deps): bump both modules, tidied together - #1269
Merged
Merged
Conversation
Takes the two open Dependabot proposals as one change: test/e2e requires the root module through a replace directive and the E2E job asserts that module is tidy, so a root-only modernc.org/sqlite bump leaves test/e2e/go.mod's indirect requires stale and cannot pass CI on its own, which is how #1267 failed as authored. Supersedes #1267 and #1268.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the two open Dependabot proposals as one change.
test/e2erequires the root module through areplacedirective, and the E2E job assertsthat module is tidy. A root-only
modernc.org/sqlitebump therefore leavestest/e2e/go.mod's indirect requires stale —modernc.org/libcandmodernc.org/sqlitestill pinned to the old versions — and cannot pass CI on its own. That is how #1267 failed
as authored: every other check green,
E2E Testsred. #1268 is e2e-only and passes, butmerging it first would leave #1267 needing the same tidy anyway.
Same situation and same resolution as #895 (which superseded #889/#890) and #786.
What moves
Root:
modernc.org/sqlite1.58.0 → 1.59.0modernc.org/libc1.75.6 → 1.75.7 (indirect)test/e2e:aws-sdk-go-v2/config1.33.4 → 1.33.5aws-sdk-go-v2/credentials1.20.4 → 1.20.5aws-sdk-go-v2/service/dynamodb1.68.0 → 1.69.0aws-sdk-go-v2/service/ec21.332.0 → 1.335.0aws-sdk-go-v2/service/lambda1.90.1 → 1.108.0aws-sdk-go-v2/service/sns1.39.17 → 1.47.1aws-sdk-go-v2/service/sts1.50.0 → 1.51.0aws/smithy-go1.28.1 → 1.28.2modernc.orgindirects the root bump propagatesBoth modules were re-tidied after applying both proposals, which is the step neither
Dependabot PR can take.
Supersedes #1267 and #1268.