Card art accessibility improvements - #114
Merged
Merged
Conversation
crookedneighbor
commented
May 10, 2025
| type_line: "<type line>", | ||
| set: "<set code>", | ||
| image_uris: makeImageUris(), | ||
| image_uris: makeImageUris(overrides.name), |
Collaborator
Author
There was a problem hiding this comment.
this is so that the image uri does change for the computed property, so the watch on the imageUri does trigger.
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| text-align: center; |
Collaborator
Author
There was a problem hiding this comment.
both the style changes here are to make the text and x in error overlay be centered.
| :src="imageUri" | ||
| :onload="onLoad" | ||
| :onerror="onError" | ||
| data-testid="card-art-preload" |
Collaborator
Author
There was a problem hiding this comment.
needed to add a data-testid here to target it in the test to trigger the load and error events.
| <div class="shape-x"></div> | ||
| <div> | ||
| <div class="shape-x"></div> | ||
| <p>There was an error loading the card art.</p> |
Collaborator
Author
There was a problem hiding this comment.
Thoughts on the wording here?
Collaborator
There was a problem hiding this comment.
this can also occur if we get a server error from the random endpoint, I think.
There was an error loading the next card. You should skip this one.
crookedneighbor
commented
May 10, 2025
scarletcs
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.