Skip to content

Feat/disabled prop - #26

Merged
scrollDynasty merged 3 commits into
mainfrom
feat/disabled-prop
Jul 29, 2026
Merged

Feat/disabled prop#26
scrollDynasty merged 3 commits into
mainfrom
feat/disabled-prop

Conversation

@scrollDynasty

@scrollDynasty scrollDynasty commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

What does this PR change and why?

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / chore
  • Native change (Android Kotlin / iOS Swift)
  • Tests only

Checklist

  • I read CONTRIBUTING.md
  • I tested on Android and/or iOS (platforms I changed)
  • I ran yarn lint, yarn build, yarn typecheck, and yarn test from the repo root
  • I added or updated tests in the correct folder (see CONTRIBUTING.md — tests)
  • I updated docs if the public API changed
  • I committed yarn.lock if package.json dependencies changed
  • I did not add unnecessary dependencies
  • I removed debug logs from library code
  • I did not hardcode demo values in src/, android/, or ios/ (example app only)
  • For native changes: I considered memory leaks and scroll performance

CI

PRs to main run the full CI workflow automatically. New tests in standard locations are picked up without editing ci.yml.

Screenshots / recordings (UI changes)

If applicable, add before/after visuals.

Related issues

Fixes # (issue number)

@scrollDynasty
feat: add disabled prop to block user interaction
2f01427 
Blocks drags and taps on both platforms while leaving programmatic movement
alone - selectedIndex and the ref methods still scroll, which is what a form
locked during submit needs.

Android intercepts the gesture before the RecyclerView sees it, so a disabled
wheel also stops leaking touches to views behind it, and an in-flight fling is
cancelled when the prop flips. iOS toggles isUserInteractionEnabled on the
UIPickerView.

Appearance is deliberately untouched: the prop changes behaviour only.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@scrollDynasty, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 43cd06c6-768a-4d6b-a830-065f3f4f395f

📥 Commits

Reviewing files that changed from the base of the PR and between 24fc3c4 and 1488996.

⛔ Files ignored due to path filters (2)
  • src/__tests__/snapshots/__snapshots__/DateDrumPicker.snapshot.test.tsx.snap is excluded by !**/*.snap
  • src/__tests__/snapshots/__snapshots__/DrumPicker.snapshot.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (13)
  • README.md
  • android/src/androidTest/java/com/drumpicker/DrumPickerTapTest.kt
  • android/src/main/java/com/drumpicker/DrumPickerView.kt
  • android/src/main/java/com/drumpicker/DrumPickerViewManager.kt
  • ios/DrumPickerTests/DrumPickerWheelViewTests.swift
  • ios/DrumPickerView.mm
  • ios/DrumPickerView.swift
  • src/DateDrumPicker.tsx
  • src/DrumPicker.native.tsx
  • src/DrumPickerViewNativeComponent.ts
  • src/__mocks__/DrumPickerViewNativeComponent.tsx
  • src/__tests__/DrumPicker.test.tsx
  • src/types.ts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

scrollDynasty and others added 2 commits July 29, 2026 14:19
@scrollDynasty
test(ios): cover the disabled prop with XCTest
011970b 
Asserts that setDisabled toggles isUserInteractionEnabled on the UIPickerView
and that programmatic selection keeps working while disabled. These run in CI
through pod lib lint --test-specs=Tests, which is the only automated iOS check
available.
@scrollDynasty
Merge branch 'main' into feat/disabled-prop
1488996
@scrollDynasty
scrollDynasty merged commit 86d5ea2 into main Jul 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@scrollDynasty