Rust crypto library scanner #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: script3r <script3r@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This commit expands the API patterns for various cryptographic libraries to improve detection accuracy. Co-authored-by: script3r <script3r@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…otlin - Add comprehensive default glob patterns for all supported languages - Add support for Swift (.swift), Objective-C (.m, .mm, .M), and Kotlin (.kt, .kts) - Implement glob-based file filtering to only process source files - Update language detection to handle new file extensions - Add --patterns CLI argument for specifying patterns file path - Update README with new language support and performance optimizations - Optimize file discovery by pre-filtering with glob patterns Performance improvements: - Only processes relevant source files, skipping docs/images/binaries - Significant speedup on large repositories with many non-source files - Maintains accuracy while reducing unnecessary file processing
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Apply consistent formatting across all Rust files - Fix line length and spacing issues - Ensure code follows Rust style guidelines
- Add --progress CLI flag to show progress bar during scanning - Implement progress callback system in scanner core - Add indicatif dependency for beautiful progress bars - Show file count, percentage, and findings count in real-time - Progress bar displays: [████████████████████████████████████████] 8943/10880 files (82%) | Found 8 findings - Works with parallel processing using crossbeam channels - Optional feature - no progress shown by default - Update README with new --progress flag documentation Example usage: cryptofind --progress /path/to/large/project cryptofind --patterns custom.toml --progress --threads 8 /src
- Apply consistent formatting across all Rust files - Fix spacing and indentation issues in progress reporting code - Ensure code follows Rust style guidelines
| } | ||
| })) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
Bug: Progress Callback Fails to Track Findings
The progress callback consistently reports 0 findings. The progress thread initializes findings_count to 0 but never updates it, as it only receives file processing completion signals and doesn't track findings sent to the main findings channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
cryptofind, a fast, modular Rust scanner for third-party cryptographic libraries across multiple languages.This PR delivers the full workspace, including
scanner-corewith comment stripping and a flexible pattern engine, language-specific detectors for Go, Java, C, C++, Rust, Python, and PHP, and a CLI with JSONL/SARIF output. It includes a seededpatterns.toml, comprehensive fixtures, unit tests, and a benchmark to ensure functionality and performance.