fix: arenas render only their own art, never a story-room background - #40
Merged
Conversation
Now that arena_01..20.png all ship, drop the placeholder fallback that let gauntlet/contract arena rooms borrow a tonally-close story-mission room background. Remove ArenaPool.placeholderBackgrounds and the fallback branch in BattleScene.roomBackgroundCandidates(); an arena now resolves only "<arenaId>.png" (and the never-present "<missionId>.png"), so a missing arena image renders no background rather than a mission room. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39 (which imported
arena_08–arena_20). With all 20 arena backgrounds now shipping, this removes the placeholder fallback that let Gauntlet/Contract arena rooms borrow a story-mission room background.Changes
Game/ArenaPool.swift— delete the now-deadplaceholderBackgroundsmap (arena_NN → MissionXXX_room_Y.png) and update the header comment.Rendering/BattleScene.swift— drop the placeholder branch inroomBackgroundCandidates().Resolution order for an arena room now
<missionId>_<arenaId>.png— e.g.Gauntlet_arena_08.png(never exists)<arenaId>.png— e.g.arena_08.png✅ (always exists; the match)<missionId>.png— e.g.Gauntlet.png(never exists)No story-mission room can be selected for an arena. If an arena image were ever missing, the room renders with no background rather than borrowing a mission room.
Notes
arena_*.pngverified present and all 20 arena ids verified inMissions/ArenaRooms.json, so no arena falls through.Validation
placeholderBackgroundsreferences.hexwire-ci.🤖 Generated with Claude Code