Added error messages when connecting to ScribeAR Server#229
Merged
bennettrwu merged 3 commits intomasterfrom Nov 13, 2025
Merged
Added error messages when connecting to ScribeAR Server#229bennettrwu merged 3 commits intomasterfrom
bennettrwu merged 3 commits intomasterfrom
Conversation
angrave
reviewed
Nov 12, 2025
Collaborator
angrave
left a comment
angrave
left a comment
There was a problem hiding this comment.
Why has "rollup" been added to package-lock.json? Is it necessary dependency
Other than that it looks reasonable to me.
Collaborator
|
@bennettrwu Bennet should check the react code (and have an opinion on the rollup dependencies in package-lock.json) |
Contributor
|
rollup is a react scripts dependency. This change probably came about because |
angrave
reviewed
Nov 13, 2025
| copyStatus.azureConvoStatus = STATUS.AVAILABLE; | ||
| copyStatus.whisperStatus = STATUS.AVAILABLE; | ||
| copyStatus.streamTextStatus = STATUS.AVAILABLE; | ||
| copyStatus.scribearServerStatus = STATUS.NULL; |
Collaborator
There was a problem hiding this comment.
It would be very helpful to explain WHY this is special ie. we want to keep this unchanged (whereas the others are reset)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.