Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Thanks so much for the PR, @catreedle! Let's discuss this a bit in the sync later today, and we'll try to bring this in tomorrow at the latest 😊 |
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| import Foundation | ||
|
|
||
| /** ContractManager is responsible for loading and caching DataContract instances |
There was a problem hiding this comment.
I'm reading Microsoft's Swift guide and they suggest always doing /// comments, at least for doc string. I think we can also do this at the file level. Let's plan on doing this in the future! I'll likely go through and fix this after we merge a few PRs in 😊
| let fallbackGender: String? | ||
| } | ||
|
|
||
| /**Builds the appropriate gender queries based on the contract structure |
There was a problem hiding this comment.
Similarly here let's do /// docstring comments. I'll likely fix after so we don't need to worry about merge conflicts 😊
| return [] | ||
| } | ||
|
|
||
| // MARK: - Private Helper Methods |
There was a problem hiding this comment.
No need for the - after // MARK: :)
| @@ -0,0 +1,107 @@ | |||
| // SPDX-License-Identifier: GPL-3.0-or-later | |||
There was a problem hiding this comment.
praise: This file was extremely easy to follow, @catreedle! Thanks for the great work :)
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's working really well here, @catreedle! So amazing to have this first step towards contracts coming in so we can use variable data :) Code is well thought out and we're removing what we don't need anymore.
note: Really sorry about the review time here :( Let's discuss in the sync if there's a way to make sure that we're getting you the support you need more consistently! Thanks for keeping at all of this!
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Changes for noun annotation:
Tested with noun annotations display correct genders
Changes for Plural command:
Tested with:
Related issue