Skip to content

Task: Scribe Logo to X icon#39

Merged
andrewtavis merged 5 commits intoscribe-org:mainfrom
priyankaforu:feature/Scribe-logo-to-x-and-settings
Oct 18, 2025
Merged

Task: Scribe Logo to X icon#39
andrewtavis merged 5 commits intoscribe-org:mainfrom
priyankaforu:feature/Scribe-logo-to-x-and-settings

Conversation

@priyankaforu
Copy link
Contributor

Contributor checklist


Description

Added toggle to switch from "Scribe Logo" to "X" and also "Added Icons for all the commands like Translate..."
Refactored the code a little because there are many icons now, so it's better to define sizes to make it dynamic

What is added/modified here ?

  • Added show_menu boolean state to control menu visibility
  • Implemented ToggleMenu and Settings message handlers
  • Created helper methods create_icon_button() and create_command_button() for consistent button generation
  • Made icon size constants (ICON_SIZE, LOGO_ICON_SIZE, BUTTON_ICON_SIZE) to maintain consistent sizing across different icon types and improve code maintainability
  • Preserved original spacing, padding, and window dimensions

@henrikth93 and @andrewtavis could you please have a look this screen recording and also the code as well and let me know if I need to change something here

working.mov

33

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Desktop rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 13, 2025 20:33
@andrewtavis
Copy link
Member

Lots of great additions here, @priyankaforu :) Thanks so much for your hard work! Some comments:

  • I guess if we have the icons it would make sense to left justify the button content rather than center it
  • Can we have the commands not be visible until the user has pressed the Scribe key as is shown in the designs?
    • It should just be the Scribe key and the text input at first
    • Then pressing the Scribe key shows all the other buttons

With the above we should be good to merge 😊

@henrikth93
Copy link
Member

henrikth93 commented Oct 14, 2025

Lots of great additions here, @priyankaforu :) Thanks so much for your hard work! Some comments:

  • I guess if we have the icons it would make sense to left justify the button content rather than center it

  • Can we have the commands not be visible until the user has pressed the Scribe key as is shown in the designs?

    • It should just be the Scribe key and the text input at first
    • Then pressing the Scribe key shows all the other buttons

With the above we should be good to merge 😊

I agree with Andrew on those points.
Feel free to reach out if you want to discuss implementing it, Priyanka.
A very good contribution though!

@priyankaforu
Copy link
Contributor Author

Lots of great additions here, @priyankaforu :) Thanks so much for your hard work! Some comments:

  • I guess if we have the icons it would make sense to left justify the button content rather than center it

  • Can we have the commands not be visible until the user has pressed the Scribe key as is shown in the designs?

    • It should just be the Scribe key and the text input at first
    • Then pressing the Scribe key shows all the other buttons

With the above we should be good to merge 😊

I completely agree with this, it's my bad , I just have overlooked into the designs, and didn't notice what was really important here , not showing the commands till, the user clicks. I will fix it and thanks for the valuable feedback @andrewtavis , that means a lot

@priyankaforu
Copy link
Contributor Author

Screen.Recording.2025-10-15.at.2.06.46.PM.mov

Hey @andrewtavis and @henrikth93 , please have a look at these changes and give feedback in your free time 😊

Copy link
Member

@henrikth93 henrikth93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the is_executing_command is being toggled and is switching between true and false, and that is not what we want. It should be set to false.

}
}
Message::ToggleTooltips => {
self.is_executing_command = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep this line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise I think it looks good, and it works well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it, thanks for the feedback @henrikth93

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking good on my end as well, @priyankaforu! 🎉

Minor edits are just from making sure that the icons are the same size as I noticed that one was a bit smaller than the others. Along with that came some MARK:s in the code as that's how we tend to do section names 😊

Thank you so much! 🙌

@andrewtavis andrewtavis merged commit baf974c into scribe-org:main Oct 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants