Task: Scribe Logo to X icon#39
Conversation
Thank you for the pull request! ❤️The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Lots of great additions here, @priyankaforu :) Thanks so much for your hard work! Some comments:
With the above we should be good to merge 😊 |
I agree with Andrew on those points. |
I completely agree with this, it's my bad , I just have overlooked into the designs, and didn't notice what was really important here , not showing the commands till, the user clicks. I will fix it and thanks for the valuable feedback @andrewtavis , that means a lot |
Screen.Recording.2025-10-15.at.2.06.46.PM.movHey @andrewtavis and @henrikth93 , please have a look at these changes and give feedback in your free time 😊 |
henrikth93
left a comment
There was a problem hiding this comment.
Now the is_executing_command is being toggled and is switching between true and false, and that is not what we want. It should be set to false.
| } | ||
| } | ||
| Message::ToggleTooltips => { | ||
| self.is_executing_command = false; |
There was a problem hiding this comment.
I think we need to keep this line
There was a problem hiding this comment.
Otherwise I think it looks good, and it works well
There was a problem hiding this comment.
fixed it, thanks for the feedback @henrikth93
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's looking good on my end as well, @priyankaforu! 🎉
Minor edits are just from making sure that the icons are the same size as I noticed that one was a bit smaller than the others. Along with that came some MARK:s in the code as that's how we tend to do section names 😊
Thank you so much! 🙌
Contributor checklist
Description
Added toggle to switch from "Scribe Logo" to "X" and also "Added Icons for all the commands like Translate..."
Refactored the code a little because there are many icons now, so it's better to define sizes to make it dynamic
What is added/modified here ?
@henrikth93 and @andrewtavis could you please have a look this screen recording and also the code as well and let me know if I need to change something here
working.mov
33
Xwhen selecting a command #33