Skip to content

Prohibit writing to the text input if not in command mode#38

Merged
andrewtavis merged 1 commit intoscribe-org:mainfrom
henrikth93:henrikt93-textinput-fix
Oct 12, 2025
Merged

Prohibit writing to the text input if not in command mode#38
andrewtavis merged 1 commit intoscribe-org:mainfrom
henrikth93:henrikt93-textinput-fix

Conversation

@henrikth93
Copy link
Member

This commit will implement a functionality that prohibits a user from writing to the text input if we are not in command mode.

Contributor checklist


Description

Related issue

@priyankaforu My fix did not involve a lot of code, so I thought I did it myself, but I want you to review it and see what you think. Feel free to come with suggestions!

This commit will implement a functionality that prohibits a user from writing to the text input if we are not in command mode.
@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Desktop rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Do you want to give some initial feedback here, @priyankaforu? :)

@priyankaforu
Copy link
Contributor

Do you want to give some initial feedback here, @priyankaforu? :)

I see everything is perfect @henrikth93. It's the best thing to have is_executing_command: bool to track the messages like "Translate/conjugate/plural". I don't find any issues here, and it's good to go !!

@andrewtavis andrewtavis self-requested a review October 12, 2025 11:58
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked and all's working well :) Thanks for the initial review, @priyankaforu! Thanks as well for the great work here, @henrikth93 😊

@andrewtavis andrewtavis merged commit 7d2dbe5 into scribe-org:main Oct 12, 2025
2 checks passed
@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accepted as a part of Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants