Skip to content

Misc: Update how the app runs itself when called#29

Merged
andrewtavis merged 3 commits intoscribe-org:mainfrom
RyanPaulGannon:binary-cleanup
Jul 15, 2025
Merged

Misc: Update how the app runs itself when called#29
andrewtavis merged 3 commits intoscribe-org:mainfrom
RyanPaulGannon:binary-cleanup

Conversation

@RyanPaulGannon
Copy link
Collaborator

Contributor checklist


Description

After reviewing the last PR, it appeared the app wasn't listening and after checking it appears that the cargo run --bin scribe only ran the gui, so this was updated in the Cargo.toml to show the two binaries used for Scribe and then run main.rs to ensure both gui and listener ran. This has also changed the run command to cargo run.

Related issue

  • N/A

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Desktop rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Jul 13, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review July 13, 2025 23:12
@andrewtavis
Copy link
Member

Quick check here, @RyanPaulGannon :) From the PR commit text I'd assume that this'd fix that the keystrokes aren't being registered and outputted to the terminal anymore, but then on the branch it doesn't appear to be happening still. Is there something I'm not seeing from the changes?

@RyanPaulGannon
Copy link
Collaborator Author

Hey @andrewtavis! Just to double check, when I click the Scribe button, it allows keystrokes (which I think was an earlier change?). So, I can look to having it so it reads the keystrokes from the moment the app opens (which I believe was the initial setup - I wasn't sure if it had been agreed to change, so I didn't want to make any adjustments to that just incase)?
Screenshot 2025-07-14 at 09 34 24

@andrewtavis
Copy link
Member

Ah yes, I get it now :) It should be reading in keystrokes at all times as even when we're not doing a command we can show people what the gender of a noun is after they type it :)

@RyanPaulGannon
Copy link
Collaborator Author

@andrewtavis, give that a test please and let me know its working for you! Took me a while, but then realised the height of the app needed raising, I guess altering font size would also work too :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working really well, @RyanPaulGannon! I must have also rejected VS Code's access to the keyboard at some point randomly, so that's why it wasn't working at all. Nice that this is at the state that it is now! Perfect starting spot for building it up 😊

@andrewtavis andrewtavis merged commit 6abba5c into scribe-org:main Jul 15, 2025
1 check passed
@RyanPaulGannon
Copy link
Collaborator Author

Perfect, progress is looking good! 😄

@RyanPaulGannon RyanPaulGannon deleted the binary-cleanup branch July 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants