Misc: Update how the app runs itself when called#29
Misc: Update how the app runs itself when called#29andrewtavis merged 3 commits intoscribe-org:mainfrom
Misc: Update how the app runs itself when called#29Conversation
Thank you for the pull request! ❤️The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Quick check here, @RyanPaulGannon :) From the PR commit text I'd assume that this'd fix that the keystrokes aren't being registered and outputted to the terminal anymore, but then on the branch it doesn't appear to be happening still. Is there something I'm not seeing from the changes? |
|
Hey @andrewtavis! Just to double check, when I click the Scribe button, it allows keystrokes (which I think was an earlier change?). So, I can look to having it so it reads the keystrokes from the moment the app opens (which I believe was the initial setup - I wasn't sure if it had been agreed to change, so I didn't want to make any adjustments to that just incase)? |
|
Ah yes, I get it now :) It should be reading in keystrokes at all times as even when we're not doing a command we can show people what the gender of a noun is after they type it :) |
|
@andrewtavis, give that a test please and let me know its working for you! Took me a while, but then realised the height of the app needed raising, I guess altering font size would also work too :) |
andrewtavis
left a comment
There was a problem hiding this comment.
All's working really well, @RyanPaulGannon! I must have also rejected VS Code's access to the keyboard at some point randomly, so that's why it wasn't working at all. Nice that this is at the state that it is now! Perfect starting spot for building it up 😊
|
Perfect, progress is looking good! 😄 |

Contributor checklist
Description
After reviewing the last PR, it appeared the app wasn't listening and after checking it appears that the
cargo run --bin scribeonly ran the gui, so this was updated in theCargo.tomlto show the two binaries used for Scribe and then runmain.rsto ensure both gui and listener ran. This has also changed the run command tocargo run.Related issue