Add explicit Windows WASAPI input AEC support#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit Windows-only
StreamConfig::windows_input_aecflag that lets callers request endpoint Acoustic Echo Cancellation for WASAPI input streams.When enabled for a capture endpoint, the WASAPI backend:
AudioCategory_CommunicationsbeforeIAudioClient::InitializeIAcousticEchoCancellationControlUnsupported devices continue recording normally; AEC setup is fail-open.
Details
Defaults the flag to
falsefromSupportedStreamConfig::config().Applies AEC only when the stream is a WASAPI capture/input endpoint.
Keeps output/loopback/system-audio capture behavior unchanged.
Testing