fix(1acp): bump submodule for codex custom-model patch (Fixes #43)#46
Merged
Conversation
Bumps modules/1acp from b54f87e to 9ca943a, pulling in the pnpm patch for @agentclientprotocol/codex-acp@0.0.44 so web chat honors the model set in ~/.codex/config.toml (e.g. a custom provider's MiniMax-M3) instead of being forced onto codex-acp's built-in default (gpt-5.5). See 1acp#2. Upstream fix: agentclientprotocol/codex-acp#199. Fixes #43 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
modules/1acpb54f87e→9ca943a, pulling in the pnpm patch that makes web 对话(codex)honor themodelin~/.codex/config.tomlfor custom providers, instead of codex-acp forcing its built-in default (gpt-5.5).Background
codex-acp's
createModelId()looked up the configured model in codex'slistModels()catalog and, when absent (custom-provider models aren't catalogued), substitutedisDefault(gpt-5.5), pinning it onto every turn →unknown model 'gpt-5.5'. The patch keeps the configured model id when it isn't in the catalog, mirroring the Codex CLI.Verification
session/newcurrentModelIdgpt-5.5→MiniMax-M3[high].unknown model.Links
Fixes #43