Update lodash to address audited vulnerability#68
Closed
sievins wants to merge 1 commit into
Closed
Conversation
Author
|
Closing in favour for #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the high severity vulnerability reported by GitHub and npm audit when installing tap-spec.
Issue reference: #67
The current version of lodash (4.17.10) that tap-spec depends on has a high severity vulnerability. Lodash applied a fix for 4.17.13.
The vunerablity only affects the following lodash functions,
merge,mergeWithanddefaultsDeep, which aren't actually used in this library. But it would be nice to upgrade it anyway as it would mean that consumers of tap-spec can trust the library implicitly. At the moment GitHub (and npm audit) alerts users of this vulnerability when installing tap-spec and you have to manually check that the library doesn't use the above lodash functions.Thanks 😄