Remove unnecessary PR updates for indirect children#23
Merged
Phlogistique merged 3 commits intomainfrom Dec 30, 2025
Merged
Conversation
The action now only updates direct children of a merged PR. Indirect descendants (grandchildren, etc.) are intentionally not modified. This simplification is possible because: - PR diffs remain correct without updating indirect children - The merge-base calculation still works correctly since the synthetic merge commit includes the original parent commit as an ancestor - Indirect children become direct children when their parent is merged, at which point they get updated properly Benefits: - Simpler code: removed ~140 lines - Fewer API calls and git operations - No risk of cascading merge conflicts through the stack - Clearer mental model: each merge only affects direct children The e2e tests still verify that indirect children's diffs remain correct after their grandparent is merged.
- Remove unused simulate_delete_remote_branch() helper function - Actually verify feature3 wasn't modified instead of just logging
github-actions
bot
deleted the
claude/remove-indirect-pr-updates-Y3fw2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action now only updates direct children of a merged PR. Indirect descendants (grandchildren, etc.) are intentionally not modified.
This simplification is possible because:
Benefits:
The e2e tests still verify that indirect children's diffs remain correct after their grandparent is merged.