Repository navigation
feat: Name the app's version and project in its user agent - #37
Merged
Merged
Conversation
Every request now ends its Safari user agent with Scrollkeeper/<version> (+https://github.com/scooper4711/scrollkeeper) instead of a fixed Scrollkeeper/1.0, so Paizo can tell releases apart, measure the app's load and block it if it ever has to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Every request already carried
Scrollkeeper/1.0after Safari's user agent. It now carries the app's real version (CFBundleShortVersionString) and the project link:So Paizo can tell the app's traffic apart by release, measure its load, find the project, and block it at the server if it ever has to. The Safari prefix stays so paizo.com serves the app as it serves a browser.
URLSessionHTTPClient.userAgent(version:)builds it; the version comes from the bundle, or "0" without one (unit tests).docs/specs/library-manager/.Checks: lint clean, 273 unit tests pass, ScrollkeeperKit coverage 97.2% lines / 94.3% regions. paizo.com's public sign-in page answers 200 with the same content for the new user agent as for the old.