Skip to content

Run the iPad app on the iPhone too - #35

Merged
scooper4711 merged 2 commits into
mainfrom
feat/iphone
Oct 20, 2026
Merged

scooper4711 merged 2 commits into
mainfrom
feat/iphone

Conversation

@scooper4711

@scooper4711 scooper4711 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Closes #34

Summary

  • Adds iPhone to the device family (TARGETED_DEVICE_FAMILY 1,2).
  • On a compact window, the split view collapses to one screen at a time: a phone toolbar (filters, downloads, a view menu, Check for New Titles, Settings) and the list in place of the columns view.
  • The inspector opens as a sheet bound to an unsaved showsPhoneDetails flag, so launch does not show an empty sheet.
  • Sheets drop their Mac-sized minimums; the downloads popover keeps its popover adaptation.
  • Adds PhoneLayoutUITests and updates the library-manager spec (design and requirement 10.9) and the README.

Testing

  • make lint clean.
  • make coverage: 272 tests in 45 suites pass; ScrollkeeperKit at 97.2% lines, 94.3% regions.
  • All UI tests pass on an iPhone 17 Pro simulator (iOS 26.5), including the new PhoneLayoutUITests, and on iPad simulators (iOS 26.5 and 27.0), where the iPhone tests are skipped. They are not part of make coverage.

🤖 Generated with Claude Code

Add iPhone to the device family and collapse the split view to one
screen at a time on a compact window. The phone gets a toolbar with
the filters, downloads, a view menu, Check for New Titles and
Settings, and shows the list instead of the columns view. The
inspector opens as a sheet bound to an unsaved flag so launch does
not show an empty sheet. Sheets drop their Mac-sized minimums, and the
UI tests run on an iPhone simulator.

Refs #34
@scooper4711
scooper4711 merged commit b2ce5d5 into main Oct 20, 2026
3 of 4 checks passed
@scooper4711
scooper4711 deleted the feat/iphone branch October 20, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPhone support

1 participant