Repository navigation
Make the flaky fetchingStopsAtTheFirstFailure test deterministic - #29
Merged
Merged
Conversation
c fails only after a retry, two requests, while d, e and f answered at once, so at times they finished first and g was asked for. d's lookup now waits until it is canceled, so c's failure always lands while d runs, and the test expects exactly a and b, and no request for e. FileStatusFetcher itself was right: it returns what it learned before the failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test let c's failure (two requests, with the retry) race against d, e and f, which answered at once, so g was sometimes asked for. The test now holds d's lookup until it is canceled, so the failure always lands while d is running. It expects exactly a and b to be learned, c to be tried twice, and e never to be asked for. Passed 10 of 10 repeated runs; FileStatusFetcher is unchanged.
Closes #27