Repository navigation
Open from Scrollkeeper like Pluck - #9
Merged
Merged
Conversation
Scrollkeeper's list and status links arrive as open events while the picker is up. With a sheet on the frontmost document window, SwiftUI gave each one a new document window instead, which hid the picker and failed to show the link as a map. A separate window, as in Pluck, avoids that.
The list and status links Scrollkeeper sends arrive as open events. SwiftUI handed them to the document window, which accepts every event, and brought it in front of the picker. The picker now takes them while it is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollkeeper://index?app=mapsmithfor its list instead of readingmaps.json, which a sandboxed app can't read.mapsmith://handoffstatus links, replacing the one-second rereading ofmaps.json.Info.plistdeclares themapsmithscheme and imports the.scrollkeeperindextype.Needs scooper4711/scrollkeeper#25 (Scrollkeeper PR "Hand Mapsmith its list and download status").
Testing
make lint: clean.make coverage: 61 tests in 9 suites pass. MapsmithCore coverage is 98.0% lines and 89.2% regions (threshold 80%).Closes #4