docs: frontend extraction refactor map + fix admin report delete - #1
Open
DariuszJustynski wants to merge 3 commits into
Open
DariuszJustynski wants to merge 3 commits into
DariuszJustynski wants to merge 3 commits into
Conversation
Adds docs/refactor-map.md — a full migration analysis of the legacy CodeIgniter 2.x Upble codebase. Covers file classification (FRONTEND_ONLY / BACKEND_ONLY / MIXED / LEGACY_CORE_DO_NOT_TOUCH), route-to-view map, form-to-controller map, asset dependency map, DB schema summary, and prioritised migration risks. No code was modified — analysis only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The del() method called array_walk() with no arguments, causing a PHP fatal error on every admin report deletion attempt. Fixed to cast each submitted ID to int before passing the array to the model. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Converts all 32 PHP view files (public, auth, admin, email) into clean
HTML templates with {{placeholder}} syntax. Copies all static assets
(Blueprint CSS, jQuery, Colorbox, Uploadify, Bootstrap 2, CKEditor,
images). Adds docs/template-map.md mapping every template to its origin.
No files in application/, system/, index.php, or db.sql were modified.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/refactor-map.md— a complete read-only migration analysis of the legacy CodeIgniter 2.x codebase as a guide for extracting the frontend into a modern stack.application/controllers/admin/report.phpwherearray_walk()was called with no arguments, crashing every admin report deletion.What's in the refactor map
The document (
docs/refactor-map.md, 566 lines) covers:FRONTEND_ONLY,BACKEND_ONLY,MIXED, orLEGACY_CORE_DO_NOT_TOUCH<!--_ERROR-->/<!--_REDIRECT-->AJAX protocol documentedmysql_real_escape_string, Tank Auth view coupling, reCAPTCHA v1, etc.)Bug fix
admin/controllers/report.php :: del()calledarray_walk()with no arguments. Fixed to cast each submitted report ID tointbefore passing to the model — minimal, safe change.Test plan
docs/refactor-map.mdrenders correctly on GitHubarray_walkfix works (POST to/admin/report/delwith anid[]array)🤖 Generated with Claude Code