Repository navigation
Keep filter panel open while selecting, add explicit close button - #10
Closed
Ken709-mp4 wants to merge 6 commits into
Closed
Ken709-mp4 wants to merge 6 commits into
Ken709-mp4 wants to merge 6 commits into
Conversation
added 6 commits
August 30, 2026 15:31
… panels, custom menu bg color - Move star-rating filter (0–5) from searchbar into #color-filter dropdown panel. - Apply shared .glass liquid-glass style to color-filter, dialogs, preview panel, and selection bar. - Add Liquid Glass theme in Settings alongside Dark/Light. - Add custom menu background color picker, persisted via Tauri set_setting/get_setting. - Update zh-CN / en-US / messages locales.
…lose × - Add a small ✕ close button to #color-filter so users can make multiple selections without the panel closing.\n- Stop click events inside the panel from bubbling, preventing accidental close.\n- Fix clearSharedFilters to reset checkbox-based rating filter instead of setting .value on a <div>.\n- Update i18n (zh-CN/en-US/messages.js) with filterPanelClose.
… close × - Replace flat backgrounds with radial gradient and glassmorphism across sidebar, searchbar, cards, toolbars, statusbar.\n- Add hover/active transitions and scale effects to buttons and cards.\n- Add fadeIn/scaleIn entry animations for cards, dialogs, preview, and filter panel.\n- Remove the explicit ✕ close button from #color-filter.\n- Keep the existing toggle behavior: click 筛选 again to close the dropdown.\n- Clean up filterPanelClose i18n key and related listeners.
- Replace <select> dropdown for semantic/tag search with two pill buttons matching the filter panel style.\n- Add horizontal padding to .view so main content no longer stretches edge-to-edge.\n- Keep searchbar, toolbar, and statusbar spanning full width inside padded views.\n- Fix duplicate semantic-search-input id in HTML.
…boxes - Add left margin and max-width to .settings so the frame no longer hugs the left edge.\n- Make the edit-tag/confirm/rate dialogs more transparent (lighter glass).\n- Replace the rejects view rating dropdown with checkbox set inside #reject-cond-panel, matching the photos filter panel.\n- Share activeRatings Set between photos and rejects; update clear/reset logic.
renderFilterDots, renderRejectConds and renderRejectRatings run at module-load time with the default en-US locale. After initI18n() resolves the saved language and applyStaticI18n() updates static text, re-render these dynamic panels so the saved locale is reflected on first paint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Keep filter panel open while selecting, add explicit close button
Problem
The filter dropdown panel (
#color-filter) felt like it closed after a single selection, making it cumbersome to pick multiple ratings, colors, lenses, or focal values in one go.Changes
Explicit close button
✕button in the top-right corner of#color-filter.Panel stays open during multi-select
e.stopPropagation()on the panel itself, so clicks on ratings, colors, lenses, or focal inputs no longer bubble up and close the dropdown accidentally.Cleanup
clearSharedFilters()to reset the checkbox-based rating filter correctly (it was trying to set.valueon the checkbox container).ratingFilterEl.value = String(minRating)sync from the rejects view rating dropdown.i18n
photos.filterPanelClosekey tozh-CN.json,en-US.json, andmessages.js.Files changed
src/index.htmlsrc/styles.csssrc/app.jssrc/locales/zh-CN.jsonsrc/locales/en-US.jsonsrc/locales/messages.jsVerification
npm run tauri devcompiled and opened the app window.node -c src/app.jspassed.