Add support for firefly fanout#51
Merged
Merged
Conversation
This is our first AI-assited commit: so much for having fun when programming :P Co-authored-by: ShawnMcKee <3066214+ShawnMcKee@users.noreply.github.com> Co-authored-by: Pablo Collado Soto <pcolladosoto@gmx.com>
Co-authored-by: ShawnMcKee <3066214+ShawnMcKee@users.noreply.github.com> Co-authored-by: Pablo Collado Soto <pcolladosoto@gmx.com>
This was referenced Mar 3, 2026
Member
Author
|
Hi @ShawnMcKee! Could you take a look at and validate this PR? I simply trimmed stuff a bit and condensed #49 and #50 into a single PR. Thanks again! |
ShawnMcKee
approved these changes
Mar 3, 2026
ShawnMcKee
left a comment
ShawnMcKee
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Once new RPMs are ready, I can test them out on my perfSONAR deployment. - Shawn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to forward incoming fireflies verbatim to an arbitrary set of receivers. This functionality is required when leveraging
flowd-goonperfSONARdeployments.Please note this PR is based on the changes proposed by @ShawnMcKee on #49 and #50. This PR simply merges the proposed set of changes and trims the log so as not to bloat it.