Open
Conversation
nvaytet
commented
Mar 9, 2026
| - version: '${{needs.formatting.outputs.min_python}}' | ||
| tox-env: '${{needs.formatting.outputs.min_tox_env}}' | ||
| python: ['${{needs.formatting.outputs.min_python}}'] | ||
| tox-env: ['${{needs.formatting.outputs.min_tox_env}}', 'package-test', 'minimal', 'noplotly'] |
Member
Author
There was a problem hiding this comment.
I changed the CI setup slightly, because I don't want to run the package test for every tox env...
| type: string | ||
|
|
||
| jobs: | ||
| package-test: |
Member
Author
There was a problem hiding this comment.
Replaced this by a tox-env for the package test to avoid running it for every tox env (normal tests, minimal, noplotly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We enable the
minimalandnoplotlytox envs in the CI (mostly for PRs).These envs existed but were never run (probably forgotten after a copier update, but I didn't manage to trace it down).
Also then envs in the requirements files were broken:
minimalhad all the test deps in it, whilenoplotlyactually installedplotly...Unfortunately, this breaks a little away from the copier template.