control&daemon: rework metrics throughout the code#4879
Open
lukedirtwalker wants to merge 1 commit into
Open
Conversation
lukedirtwalker
added a commit
to Anapaya/os-scion
that referenced
this pull request
Feb 12, 2026
Switch to use metrics/v2 everywhere in control&daemon code and in all the libraries they use. Don't have any internal magically create metrics, instead inject all metrics from the outside, so that the user of a library is in full control of what metrics get exposed. With the newly introduced option pattern for metrics it's also possible to select the registry as well as customizing the collector for certain metrics, this can for example be leveraged to only expose certain metrics on demand. Upstream PR: scionproto#4879
Switch to use metrics/v2 everywhere in control&daemon code and in all the libraries they use. Don't have any internal magically create metrics, instead inject all metrics from the outside, so that the user of a library is in full control of what metrics get exposed. With the newly introduced option pattern for metrics it's also possible to select the registry as well as customizing the collector for certain metrics, this can for example be leveraged to only expose certain metrics on demand.
lukedirtwalker
force-pushed
the
metrics-rework
branch
from
b97593a to
7ce163c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to use metrics/v2 everywhere in control&daemon code and in all the libraries they use. Don't have any internal package magically create metrics, instead inject all metrics from the outside, so that the user of a library is in full control of what metrics get exposed.
With the newly introduced option pattern for metrics it's also possible to select the registry as well as customizing the collector for certain metrics, this can for example be leveraged to only expose certain metrics on demand.