ENH: Add no-artifact-state to avoid a red status when none is wanted - #134
Merged
Merged
Conversation
A job that uploads no artifacts goes red, which is right when the artifacts were expected and noise when they were not -- a "[skip circle]" commit in scipy/scipy#25771, where the CircleCI job halts by design. no-artifact-state (failure, the default, / success / skip) picks what that case posts, for both front ends. There is deliberately no grey: a commit status has no neutral state, and pending would be a yellow one that never resolves; real grey would mean posting check runs instead, which costs every action user a checks: write permission and every App installation a re-approval. An unknown value throws rather than being guessed at, which the action reports via setFailed and the App as a failed delivery. Also document, in CLAUDE.md, that the two front ends do not behave the same -- the App never posts a pending status, so post-pending caveats are action-only -- and refresh the roster of which repo is on which. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lucascolley this should allow SciPy to use
no-artifact-state: skipto just not put anything in when the named artifact is missing (or: successto put a link to the job even though the file is missing). Sound good?