Fix World.step reverting to fixed time step with 0 timeSinceLastCalled#337
Open
Grimeh wants to merge 1 commit intoschteppe:masterfrom
Open
Fix World.step reverting to fixed time step with 0 timeSinceLastCalled#337Grimeh wants to merge 1 commit intoschteppe:masterfrom
Grimeh wants to merge 1 commit intoschteppe:masterfrom
Conversation
Calling World.step with a `timeSinceLastCalled` of 0 would cause it to revert to the fixed time step behaviour. This was due to the default value of `timeSinceLastCalled` being 0. This change checks for `undefined`, as opposed to 0. See issue schteppe#334 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling World.step with a
timeSinceLastCalledof 0 would cause it to revertto the fixed time step behaviour. This was due to the default value of
timeSinceLastCalledbeing 0. This change checks forundefined, as opposedto 0.
maxSubStepsstill has a default value of 10.See issue #334 for more details.