Fixed inefficient way of resetting an object#321
Open
issy123 wants to merge 1 commit intoschteppe:masterfrom
Open
Fixed inefficient way of resetting an object#321issy123 wants to merge 1 commit intoschteppe:masterfrom
issy123 wants to merge 1 commit intoschteppe:masterfrom
Conversation
Looping through all object keys to delete them is very inefficient, rather remove the reference to the object and create a new object. The garbage collector is efficient enough to handle this.
Contributor
|
Just for some historical context, the reason I did it this way was because there actually were GC pause issues with allocating a new object. The compromise was to be slightly slower to run, but consistent. Rather than sometimes being faster, but spiking on GC. |
Author
|
Well it is significant faster I my experience with node v6+. What would you suggest? |
Contributor
|
I always suggest measuring it, a benchmark suite that proves one thing or another is faster is always great. |
|
We need a benchmark for many browsers and different versions of nodejs for this one :/ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looping through all object keys to delete them is very inefficient, rather remove the reference to the object and create a new object. The garbage collector is efficient enough to handle this.