Conversation
…l to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2314720 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30207 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-1049003 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30772 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2436751 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-31409 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-31503 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-608097 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2320014 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30770 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-31495 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-32477 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-451611 - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSFILEUPLOAD-30401 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30771 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30778 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-451610 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-2635340 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2321524 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-608098 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGFREEMARKER-1076795 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30774 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-609765 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30799 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30803 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-30163 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1009832 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-30165 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGZEROTURNAROUND-31681 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2327339 - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSIO-1277109 - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSFILEUPLOAD-30082 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30060 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30775 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30776 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-31500 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-31501 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-31502 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30798 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30802 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-474418 - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSFILEUPLOAD-31540 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-31331 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-30773 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30800 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-30164 - https://dev.snyk.io/vuln/SNYK-JAVA-OGNL-30474 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTS-460223 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30801 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHESTRUTSXWORK-30804 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2434828 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2823313 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-31325 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2689634 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2329097 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-2330878 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-567761
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.7</version> | ||
| <version>2.13.2</version> |
There was a problem hiding this comment.
Description: It was found that the fix to address CVE-2021-44228 in Apache Log4j 2.15.0 was incomplete in certain non-default configurations. This could allows attackers with control over Thread Context Map (MDC) input data when the logging configuration uses a non-default Pattern Layout with either a Context Lookup (for example, $${ctx:loginId}) or a Thread Context Map pattern (%X, %mdc, or %MDC) to craft malicious input data using a JNDI Lookup pattern resulting in an information leak and remote code execution in some environments and local code execution in all environments. Log4j 2.16.0 (Java 8) and 2.12.2 (Java 7) fix this issue by removing support for message lookup patterns and disabling JNDI functionality by default.
Relevant link: GHSA-7rjr-3q55-vv33
Severity: Critical
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.7</version> | ||
| <version>2.13.2</version> |
There was a problem hiding this comment.
Description: Apache Log4j2 2.0-beta9 through 2.15.0 (excluding security releases 2.12.2, 2.12.3, and 2.3.1) JNDI features used in configuration, log messages, and parameters do not protect against attacker controlled LDAP and other JNDI related endpoints. An attacker who can control log messages or log message parameters can execute arbitrary code loaded from LDAP servers when message lookup substitution is enabled. From log4j 2.15.0, this behavior has been disabled by default. From version 2.16.0 (along with 2.12.2, 2.12.3, and 2.3.1), this functionality has been completely removed. Note that this vulnerability is specific to log4j-core and does not affect log4net, log4cxx, or other Apache Logging Services projects.
Relevant link: GHSA-jfh8-c2jp-5v3q
Severity: Critical
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| <version>2.7</version> | ||
| <version>2.13.2</version> |
There was a problem hiding this comment.
Description: Apache Log4j2 versions 2.0-alpha1 through 2.16.0 (excluding 2.12.3 and 2.3.1) did not protect from uncontrolled recursion from self-referential lookups. This allows an attacker with control over Thread Context Map data to cause a denial of service when a crafted string is interpreted. This issue was fixed in Log4j 2.17.0, 2.12.3, and 2.3.1.
Relevant link: GHSA-p6xc-xr62-6r2g
Severity: High
|
✅ I finished the code review, and left comments with the issues I found. |
Snyk has created this PR to fix 57 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):
todolist-goof/todolist-web-struts/pom.xmltodolist-goof/pom.xmlVulnerabilities that will be fixed with an upgrade:
SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2314720
2.7->2.13.2No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-30207
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-1049003
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-30772
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGSPRINGFRAMEWORK-2436751
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundMatureSNYK-JAVA-ORGAPACHELOGGINGLOG4J-31409
2.7->2.13.2No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-31503
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-608097
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2320014
2.7->2.13.2No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-30770
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-31495
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTS-32477
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundMatureSNYK-JAVA-ORGAPACHESTRUTSXWORK-451611
2.3.20->6.1.2No Path FoundMatureSNYK-JAVA-COMMONSFILEUPLOAD-30401
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30771
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30778
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-451610
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-2635340
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundProof of ConceptSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2321524
2.7->2.13.2No Path FoundProof of ConceptSNYK-JAVA-ORGAPACHESTRUTS-608098
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundProof of ConceptSNYK-JAVA-ORGFREEMARKER-1076795
2.3.20->6.1.2No Path FoundProof of ConceptSNYK-JAVA-ORGAPACHESTRUTS-30774
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-609765
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30799
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30803
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-30163
3.2.6.RELEASE->5.2.22.RELEASENo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-1009832
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-30165
3.2.6.RELEASE->5.2.22.RELEASENo Path FoundNo Known ExploitSNYK-JAVA-ORGZEROTURNAROUND-31681
1.12->1.13ReachableNo Known ExploitSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2327339
2.7->2.13.2No Path FoundProof of ConceptSNYK-JAVA-COMMONSIO-1277109
2.3.20->6.1.2Major version upgradeNo Path FoundMatureSNYK-JAVA-COMMONSFILEUPLOAD-30082
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30060
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30775
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30776
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-31500
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-31501
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-31502
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30798
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30802
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-474418
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-COMMONSFILEUPLOAD-31540
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-31331
3.2.6.RELEASE->5.2.22.RELEASENo Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-30773
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30800
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-30164
3.2.6.RELEASE->5.2.22.RELEASENo Path FoundNo Known ExploitSNYK-JAVA-OGNL-30474
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTS-460223
2.3.20->6.1.2org.apache.struts:struts2-spring-plugin:
2.3.20->2.5.30No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30801
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHESTRUTSXWORK-30804
2.3.20->6.1.2No Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-2434828
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-2823313
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-31325
3.2.6.RELEASE->5.2.22.RELEASENo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-2689634
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundProof of ConceptSNYK-JAVA-ORGSPRINGFRAMEWORK-2329097
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundNo Known ExploitSNYK-JAVA-ORGSPRINGFRAMEWORK-2330878
3.2.6.RELEASE->5.2.22.RELEASEMajor version upgradeNo Path FoundNo Known ExploitSNYK-JAVA-ORGAPACHELOGGINGLOG4J-567761
2.7->2.13.2No Path FoundNo Known ExploitImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)
🦉 Arbitrary Code Execution
🦉 Information Exposure
🦉 More lessons are available in Snyk Learn