Conversation
The following vulnerabilities are fixed with an upgrade: - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSCOLLECTIONS-30078 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2320014 - https://dev.snyk.io/vuln/SNYK-JAVA-COMUNBOUNDID-32143 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2321524 - https://dev.snyk.io/vuln/SNYK-JAVA-ORGAPACHELOGGINGLOG4J-2327339 - https://dev.snyk.io/vuln/SNYK-JAVA-COMMONSCOLLECTIONS-472711 - https://dev.snyk.io/vuln/SNYK-JAVA-IOUNDERTOW-2391283 - https://dev.snyk.io/vuln/SNYK-JAVA-IOUNDERTOW-3012383 - https://dev.snyk.io/vuln/SNYK-JAVA-IOUNDERTOW-2871356
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
![amazon-inspector-n-virginia[bot]](https://avatars.githubusercontent.com/u/214039647?s=60&v=4){kind=small}
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in the Undertow HTTP server core, which is used in WildFly, JBoss EAP, and other Java applications. The Undertow library fails to properly validate the Host header in incoming HTTP requests.As a result, requests containing malformed or malicious Host headers are processed without rejection, enabling attackers to poison caches, perform internal network scans, or hijack user sessions.
Relevant link: GHSA-j382-5jj3-vw4j
Severity: Critical
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: The undertow client is not checking the server identity presented by the server certificate in https connections. This is a compulsory step (at least it should be performed by default) in https and in http/2. I would add it to any TLS client protocol.
Relevant link: GHSA-pfcc-3g6r-8rg8
Severity: Critical
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A vulnerability was found in Undertow. This vulnerability impacts a server that supports the wildfly-http-client protocol. Whenever a malicious user opens and closes a connection with the HTTP port of the server and then closes the connection immediately, the server will end with both memory and open file limits exhausted at some point, depending on the amount of memory available. At HTTP upgrade to remoting, the WriteTimeoutStreamSinkConduit leaks connections if RemotingConnection is closed by Remoting ServerConnectionOpenListener. Because the remoting connection originates in Undertow as part of the HTTP upgrade, there is an external layer to the remoting connection. This connection is unaware of the outermost layer when closing the connection during the connection opening procedure. Hence, the Undertow WriteTimeoutStreamSinkConduit is not notified of the closed connection in this scenario. Because WriteTimeoutStreamSinkConduit creates a t...
Relevant link: GHSA-w6qf-42m7-vh68
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in Undertow where malformed client requests can trigger server-side stream resets without triggering abuse counters. This issue, referred to as the "MadeYouReset" attack, allows malicious clients to induce excessive server workload by repeatedly causing server-side stream aborts. While not a protocol bug, this highlights a common implementation weakness that can be exploited to cause a denial of service (DoS).
Relevant link: GHSA-95h4-w6j8-2rp8
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A vulnerability was found in Undertow, where the chunked response hangs after the body was flushed. The response headers and body were sent but the client would continue waiting as Undertow does not send the expected 0\r\n termination of the chunked response. This results in uncontrolled resource consumption, leaving the server side to a denial of service attack. This happens only with Java 17 TLSv1.3 scenarios.
Relevant link: GHSA-xpp6-8r3j-ww43
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A vulnerability was found in Undertow where the ProxyProtocolReadListener reuses the same StringBuilder instance across multiple requests. This issue occurs when the parseProxyProtocolV1 method processes multiple requests on the same HTTP connection. As a result, different requests may share the same StringBuilder instance, potentially leading to information leakage between requests or responses. In some cases, a value from a previous request or response may be erroneously reused, which could lead to unintended data exposure. This issue primarily results in errors and connection termination but creates a risk of data leakage in multi-request environments.
Relevant link: GHSA-9623-mqmm-5rcf
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in Undertow. Servlets using a method that calls HttpServletRequestImpl.getParameterNames() can cause an OutOfMemoryError when the client sends a request with large parameter names. This issue can be exploited by an unauthorized user to cause a remote denial-of-service (DoS) attack.
Relevant link: GHSA-33hj-rcmx-86mv
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in Undertow that can cause remote denial of service attacks. When the server uses the FormEncodedDataDefinition.doParse(StreamSourceChannel) method to parse large form data encoding with application/x-www-form-urlencoded, the method will cause an OutOfMemory issue. This flaw allows unauthorized users to cause a remote denial of service (DoS) attack.
Relevant link: GHSA-6h4f-pj3g-q8fq
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in Undertow package. Using the FormAuthenticationMechanism, a malicious user could trigger a Denial of Service by sending crafted requests, leading the server to an OutofMemory error, exhausting the server's memory.
Relevant link: GHSA-97cq-f4jm-mv8h
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A vulnerability was found in Undertow, where URL-encoded request paths can be mishandled during concurrent requests on the AJP listener. This issue arises because the same buffer is used to decode the paths for multiple requests simultaneously, leading to incorrect path information being processed. As a result, the server may attempt to access the wrong path, causing errors such as "404 Not Found" or other application failures. This flaw can potentially lead to a denial of service, as legitimate resources become inaccessible due to the path mix-up.
Relevant link: GHSA-9442-gm4v-r222
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in Undertow, which incorrectly parses cookies with certain value-delimiting characters in incoming requests. This issue could allow an attacker to construct a cookie value to exfiltrate HttpOnly cookie values or spoof arbitrary additional cookie values, leading to unauthorized data access or modification. The main threat from this flaw impacts data confidentiality and integrity.
Relevant link: GHSA-3jrv-jgp8-45v3
Severity: High
| <groupId>io.undertow</groupId> | ||
| <artifactId>undertow-core</artifactId> | ||
| <version>2.2.13.Final</version> | ||
| <version>2.3.0.Final</version> |
There was a problem hiding this comment.
Description: A flaw was found in undertow. This issue makes achieving a denial of service possible due to an unexpected handshake status updated in SslConduit, where the loop never terminates.
Relevant link: GHSA-m4mm-pg93-fv78
Severity: High
|
✅ I finished the code review, and left comments with the issues I found. |
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2 participants
Snyk has created this PR to fix 9 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):
log4shell-goof/log4shell-server/pom.xmlVulnerabilities that will be fixed with an upgrade:
SNYK-JAVA-COMMONSCOLLECTIONS-30078
3.1->3.2.2MatureSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2320014
2.15.0->2.17.1MatureSNYK-JAVA-COMUNBOUNDID-32143
3.1.1->4.0.5Major version upgradeNo Known ExploitSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2321524
2.15.0->2.17.1Proof of ConceptSNYK-JAVA-ORGAPACHELOGGINGLOG4J-2327339
2.15.0->2.17.1Proof of ConceptSNYK-JAVA-COMMONSCOLLECTIONS-472711
3.1->3.2.2Proof of ConceptSNYK-JAVA-IOUNDERTOW-2391283
2.2.13.Final->2.3.0.FinalNo Known ExploitSNYK-JAVA-IOUNDERTOW-3012383
2.2.13.Final->2.3.0.FinalNo Known ExploitSNYK-JAVA-IOUNDERTOW-2871356
2.2.13.Final->2.3.0.FinalNo Known ExploitImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Deserialization of Untrusted Data
🦉 User Impersonation
🦉 Denial of Service (DoS)
🦉 More lessons are available in Snyk Learn