Skip to content

Light background on dark text for subjects#85

Open
gwennlbh wants to merge 1 commit intomasterfrom
light-background-on-dark-text-for-subjects
Open

Light background on dark text for subjects#85
gwennlbh wants to merge 1 commit intomasterfrom
light-background-on-dark-text-for-subjects

Conversation

@gwennlbh
Copy link
Copy Markdown
Member

@gwennlbh gwennlbh commented May 11, 2020

Will resolve #84.

@gwennlbh gwennlbh changed the title light-background-on-dark-text-for-subjects Light background on dark text for subjects May 11, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented May 11, 2020

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.78%. Comparing base (da0c333) to head (44e2f50).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
store/index.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master     #85      +/-   ##
=========================================
+ Coverage    4.28%   4.78%   +0.49%     
=========================================
  Files          60      60              
  Lines        2169    2175       +6     
  Branches      605     605              
=========================================
+ Hits           93     104      +11     
+ Misses       1720    1715       -5     
  Partials      356     356              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwennlbh
Copy link
Copy Markdown
Member Author

I'm going to redesign all modals in the future, but for now this should be an opt-in prop on <BadgeSubject>. Right now, the only place where subject badges (not dots) are visible is on the note editor, which is broken anyway.

On the current subject picker modal it looks horrendous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Light background on dark text for subjects

1 participant