Repository navigation
Fix online fights ending by themselves above 30 fps - #93
Merged
Merged
Conversation
With 30 Hz logic the network manager task (FUN_0890E794, the battle's pad exchange FUN_0890D664) ran on every displayed frame. On the drawn-only frames the other copy's pad for the next frame was not there yet, so the exchange counted a waiting frame each time, and after the game's 900 waiting frames it ended the session without a message. The task now runs on logic frames only, as on the PSP. PSPRECOMP_L30_NET_EVERY_FRAME=1 restores the old behaviour. Checked with two copies on one machine (LAN, Online Lobby 1-on-1, Lightning vs Lightning, 120 fps): before, both left the fight about 10 s in; after, still in the fight at 90 s, and both copies show the same Bravery and HP after hits. At 30 fps (no 30 Hz logic) fights were already fine. The 900-frame timeout comes from VCKing101's notes on the game's exchange (https://github.com/VCKing101/Dissidia012-pc, docs/port/communication-mode.md). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Online fights ended silently about 10 s in at frame rates above 30.
With the 30 Hz logic from #81 the game advances on one displayed frame in two, three or four, but its network manager task (
FUN_0890E794, which runs the battle's per-frame pad exchangeFUN_0890D664) ran on every displayed frame. On the drawn-only frames the other copy's pad for the next frame was not there yet, so the exchange counted a waiting frame each time; after the game's 900 waiting frames it ended the session without a message (the timeout is from VCKing101's notes, https://github.com/VCKing101/Dissidia012-pc,docs/port/communication-mode.md). The task now runs on logic frames only, as on the PSP.PSPRECOMP_L30_NET_EVERY_FRAME=1restores the old behaviour for tests. Noted inmultiplayer.md.Checked with two copies on one machine (LAN, Online Lobby 1-on-1, Lightning vs Lightning):
Release notes
🤖 Generated with Claude Code