Skip to content

Fix online fights ending by themselves above 30 fps - #93

Merged
schindlershadow merged 1 commit into
mainfrom
fix-mp-logic30
Nov 19, 2026
Merged

schindlershadow merged 1 commit into
mainfrom
fix-mp-logic30

Conversation

@schindlershadow

Copy link
Copy Markdown
Owner

Online fights ended silently about 10 s in at frame rates above 30.

With the 30 Hz logic from #81 the game advances on one displayed frame in two, three or four, but its network manager task (FUN_0890E794, which runs the battle's per-frame pad exchange FUN_0890D664) ran on every displayed frame. On the drawn-only frames the other copy's pad for the next frame was not there yet, so the exchange counted a waiting frame each time; after the game's 900 waiting frames it ended the session without a message (the timeout is from VCKing101's notes, https://github.com/VCKing101/Dissidia012-pc, docs/port/communication-mode.md). The task now runs on logic frames only, as on the PSP. PSPRECOMP_L30_NET_EVERY_FRAME=1 restores the old behaviour for tests. Noted in multiplayer.md.

Checked with two copies on one machine (LAN, Online Lobby 1-on-1, Lightning vs Lightning):

  • 120 fps before: both copies left the fight about 10 s in (closed their sockets and left the group at the same moment, check values in agreement)
  • 120 fps after: still in the fight at 90 s; after hits both copies show the same Bravery and HP
  • 30 fps: unaffected (no 30 Hz logic), fine before and after

Release notes

  • Fixed online fights ending by themselves about 10 seconds in when playing above 30 fps.

🤖 Generated with Claude Code

With 30 Hz logic the network manager task (FUN_0890E794, the battle's pad
exchange FUN_0890D664) ran on every displayed frame. On the drawn-only frames
the other copy's pad for the next frame was not there yet, so the exchange
counted a waiting frame each time, and after the game's 900 waiting frames it
ended the session without a message. The task now runs on logic frames only,
as on the PSP. PSPRECOMP_L30_NET_EVERY_FRAME=1 restores the old behaviour.

Checked with two copies on one machine (LAN, Online Lobby 1-on-1, Lightning vs
Lightning, 120 fps): before, both left the fight about 10 s in; after, still
in the fight at 90 s, and both copies show the same Bravery and HP after hits.
At 30 fps (no 30 Hz logic) fights were already fine.

The 900-frame timeout comes from VCKing101's notes on the game's exchange
(https://github.com/VCKing101/Dissidia012-pc, docs/port/communication-mode.md).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schindlershadow
schindlershadow merged commit dc21619 into main Nov 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant