Skip to content

Japanese voices: story movies keep their English picture - #92

Merged
schindlershadow merged 3 commits into
mainfrom
jp-movie-splice
Nov 19, 2026
Merged

schindlershadow merged 3 commits into
mainfrom
jp-movie-splice

Conversation

@schindlershadow

Copy link
Copy Markdown
Owner

With Japanese voices on, jp_audio.py copied each undub movie that differs from the player's disc whole. Six of the USA undub's 34 (END, UP_END, UP_GIL, UP_OPN, UP_PRI, DES01_010) also have another picture, so those showed the undub's picture next to the game's English text.

splice_movie_audio now writes the player's own movie with the undub's sound in it: a PMF's sound is private stream 1, a 4-byte header per packet and then 752-byte ATRAC3plus frames, contiguous from the first sound byte on both discs, so the undub's sound byte n goes where the player's sound byte n is and every header stays right. DES01_010's undub sound is one frame longer: the last frame is left out. A movie whose streams do not have that layout is still copied whole. Existing movie_jp files are compared by content, not size (UP_GIL's old whole copy has the same size as the player's file). Method from VCKing101's port (https://github.com/VCKing101/Dissidia012-pc, docs/port/japanese-voices.md, "Movies", MIT).

Checked:

  • EU disc + USA undub: all 34 movies have the player's picture and the undub's sound, each byte for byte; on the user's desktop as well, after re-running the tool over an install that had whole copies
  • in game: UP_GIL served as the title movie, recorded through SDL's disk audio driver: its loudness envelope matches the undub movie's (0.999) and not the English one where the voices are
  • tools/test_jp_audio.py (new): the splice on synthetic movies (longer / shorter sound, other packet layout, a stream off the 752-byte grid is refused)

audio.md also records that the undub disc changes no story scene script (only sound files), so fixing scene timing needs the Japanese disc (NPJH-50377); that is the next step.

Release notes

  • With Japanese voices, story movies keep their English picture (six of them showed the undub disc's picture).

🤖 Generated with Claude Code

schindlershadow and others added 3 commits November 19, 2026 01:30
…d in

jp_audio.py copied each differing undub movie whole; six of the USA undub's
(END, UP_END, UP_GIL, UP_OPN, UP_PRI, DES01_010) also have another picture.
splice_movie_audio puts the undub's ATRAC3plus bytes where the installed
movie's are (752-byte frames from the first sound byte on both discs, the
packets' 4-byte headers kept); DES01_010's extra frame is left out; a movie
whose streams do not line up is still copied whole.

Checked: EU disc + USA undub, all 34 movies have the installed picture and the
undub's sound byte for byte; in game (UP_GIL served as the title movie) the
sound envelope matches the undub's movie (0.999) and not the English one.
test_jp_audio.py covers the splice on synthetic movies.

audio.md also records that the undub changes no story scene script, so the
scene timing fix needs the Japanese disc.

Method from VCKing101's port (docs/port/japanese-voices.md, MIT):
https://github.com/VCKing101/Dissidia012-pc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e disc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An earlier version copied each undub movie whole; UP_GIL's whole copy has the
same size as the installed movie, so the size check kept it (undub picture).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schindlershadow
schindlershadow merged commit bc46d86 into main Nov 19, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant