Repository navigation
Android setup app: native Android UI, live build log, log sharing; extras shared with the PC installer - #91
Open
schindlershadow wants to merge 1 commit into
Open
schindlershadow wants to merge 1 commit into
schindlershadow wants to merge 1 commit into
Conversation
…h installers
The Android setup app was the SDL wizard of setup/ drawn on a canvas. It is now native Android views
(android/setup/java, no SDL) over the same C++ install logic, reached through JNI (setup/android_engine.cpp,
built as libsetupcore.so):
- pages in the game's look (night sky, turning crystal, gold-framed cards, Cinzel / Noto Sans), animated
page changes, portrait and landscape (rotation does not disturb a running build)
- touch, keyboard and game controller (d-pad / stick, A, B, Y, L / R; hints in the top bar)
- live build log with progress, step track, elapsed time and ETA; a foreground service keeps the build going
in the background with a progress notification
- failed builds show the reason and last lines, with Share / Save / View of the log; Logs and reports lists
the build log, the game's last_run.log, the updater log and the app's own crash reports (offered once
after a crash)
- Play now after the install; install permission and all-files access resume by themselves
Extras are one list (setup/extras.cpp): titles, choices, parent switch, second disc (texts + check), steps
for both platforms (ExtraCtx tool / download), Redo / remove. The desktop Options, Change extras and disc
pages, install.ini, plan_install / plan_extras and the Android Options page and plans are made from it, so
a new extra is added once for both. Main's D1 / undub disc checks are the extras' disc.check, run by both.
Also: Python is started through the musl loader only when the patched interpreter path does not resolve
(secondary Android users); child pythons of psp_build.py / android_build.py / d1_moves.py get the same
prefix. The update check reports an error when the checker produced no answer (it said "newest version").
The desktop wizard lost its Android code paths (setup/android.{h,cpp}). files/ui_demo (run-as, debuggable
builds) runs a fake build plan for testing pages where the tools cannot run (the x86_64 emulator).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android setup app was the PC wizard's SDL canvas UI. This replaces it with native Android views (
android/setup/java, no SDL) on top of the same C++ install logic, reached through JNI (setup/android_engine.cpp→libsetupcore.so). Plans, progress parsing,install.ini, payload unpacking and process handling are not duplicated.The app
setup.log(share sheet via a read-onlyShareProvider; Save via Android's "save as" picker).last_run.log, updater log, and the app's own crash reports. After a crash, the next start offers the report once.Extras are one list for both installers (
setup/extras.cpp)features.iniline, title / help, switch or choices, parent switch, second disc (page texts +check), steps for both platforms (ExtraCtx::tool/download), and Redo / remove.install.ini,plan_install/plan_extras, and the Android Options page and plans are all made from it.disc.check, so the Android app runs them too: a wrong disc gets a dialog, and its file descriptor is closed.Also
psp_build.py,android_build.py,d1_moves.py) get the same prefix.setup/android.{h,cpp}are gone.make_skeleton.pygained--no-sdl,--extra-resand--assets. CI builds the app without SDL and compiles against android-34.Testing
test_setup_installpasses, including new cases for the shared list;--screenshotspages unchanged.SETUP_TEST_DISCS): D1 USA accepted for Bartz's moves; English 012 refused for both extras; undub accepted.extras.cppappeared and was planned in both installersfiles/ui_demotest plan (debuggable builds,run-asonly). A test APK that reuses the v0.1.18 payload has been built for phone testing.Release notes
🤖 Generated with Claude Code