Repository navigation
Fix black screen entering the Story Mode world map above 30 fps - #89
Merged
Merged
Conversation
Above 30 fps, 'Depart on a journey' in Story Mode hung on a dark blue screen: the world map runs on the battle overlay with its walker as an actor, so battle_running() was true and 30 Hz logic switched on there; going on to the menu overlay then never came back. Reproduced at 60, 120 and 240 fps (not at 30, not with PSPRECOMP_LOGIC30=0). l30_active() now also needs a fighter in the battle object (*0x089D6A10 +0x38 / +0x3C, empty on the world map; from VCKing101's notes, https://github.com/VCKing101/Dissidia012-pc). After the fix 60, 120 and 240 fps reach the world map, and a Quick Battle still switches 30 Hz logic on. Logs '[FPS] 30 Hz logic on (fight)' / 'off'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Above 30 fps, "Depart on a journey" in Story Mode hung on a dark blue screen. The world map runs on the battle overlay with its walker as an actor, so
battle_running()was true there and the 30 Hz logic from #81 switched on; going on from the world map to the menu overlay then never came back.l30_active()now also needs a fighter in the battle object (*0x089D6A10+0x38 / +0x3C, empty on the world map; the test comes from VCKing101's notes, https://github.com/VCKing101/Dissidia012-pc,docs/port/analog-movement.md). The switch is logged:[FPS] 30 Hz logic on (fight)/off.Checked on the test host (EU disc, Story Mode Prologue):
PSPRECOMP_LOGIC30=030 Hz logic on (fight)Release notes
🤖 Generated with Claude Code