Repository navigation
Installer: check the picked Dissidia 1 / undub discs; open setup.log from the failure page - #85
Merged
Merged
Conversation
…game The Dissidia 1 pick only looked for obj/p_fiv100.objx, which Dissidia 012 has too, so a 012 image was taken and the install failed later with a misleading message. Now, as soon as a file is picked (ISO or CSO, also an Android fd:N): - Dissidia 1: PARAM.SFO DISC_ID must be ULUS10437; a 012 image, another D1 release or another game is refused with what it is. - Undub: must be Dissidia 012 and must not have the English voices (Bartz's battle bank compared with the EU / US English one: size + CRC-32). A refused pick shows a WRONG DISC page whose OK goes back to choosing that file. d1_moves.py install checks the DISC_ID too. Tests: synthetic ISO / CSO images, SETUP_TEST_DISCS for real ones (D1 USA, 012 USA/EU, undub checked). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two rows on the NOT FINISHED page when the run has a setup.log (desktop only): Open setup.log (default program) and Show setup.log in its folder (Windows Explorer /select, macOS Finder -R, Linux xdg-open on the folder). If it cannot be opened, a message gives the path. setup::open_on_desktop in install.cpp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…52), and every retry then failed on the cut file Python's text files default to the ANSI code page on Windows; the D1 help texts have characters cp1252 does not have, so json.dump stopped half way and left a truncated extra_abilities.json; Try again failed on reading it. - d1_moves.py, netpack.py, roster_mainbin.py (+ charmod_objx, voice_bank, package_extract): UTF-8 for every text file - extra_abilities.json is written to .tmp and swapped in; one that does not parse is kept as .bad and written again - the wizard runs its Python steps with PYTHONUTF8=1 Checked with PYTHONWARNDEFAULTENCODING=1 PYTHONWARNINGS=error::EncodingWarning and a truncated file: installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on has a ._pth file (isolated mode), which ignores PYTHON* variables; the tools' explicit UTF-8 is the fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup wizard took a Dissidia 012 image as the Dissidia 1 disc. Its only check was for
obj/p_fiv100.objx, which 012 has too, so the install failed later with a misleading "differs from the one the patches were made from". The undub pick had no check at all.Now each picked file is checked as soon as it is chosen. It works for ISO and CSO files, and for Android's
fd:N.PSP_GAME/PARAM.SFODISC_IDmust beULUS10437. A 012 image, another D1 release, or another game is refused, and the message says what it is.6EE2B876). An image with no voice index to compare is not refused.tools/d1_moves.py installalso refuses a DISC_ID other thanULUS10437.docs/installer.mddescribes the checks.Tested
test_setup_installbuilds small ISO and CSO images in the test.SETUP_TEST_DISCSruns the checks on real images:fd:Npath was tried on real images.d1_moves.py installrefuses 012 and still installs from the right disc.Not tested
Also: on a failed install, the NOT FINISHED page has Open setup.log and Show setup.log in its folder. These are desktop only: Windows Explorer opens with the file selected, macOS uses Finder, and Linux opens the folder with xdg-open. If the log can't be opened, a message gives its path. Only the screenshot of the page was checked. Neither row was clicked on Windows.
Also: fix for Windows installs of the D1 moves. Python on Windows writes text files in cp1252. The D1 help texts contain characters cp1252 doesn't have, so
d1_moves.pycrashed halfway through writingextra_abilities.json. Every "Try again" then failed on the truncated file (seen in a user's setup.log with v0.1.18)..badand written again.This was checked with Python's default-encoding warnings turned into errors, starting from a truncated file. The install went through.
Release notes
🤖 Generated with Claude Code