Skip to content

Installer: check the picked Dissidia 1 / undub discs; open setup.log from the failure page - #85

Merged
schindlershadow merged 4 commits into
mainfrom
bartz-d1-moves
Nov 19, 2026
Merged

schindlershadow merged 4 commits into
mainfrom
bartz-d1-moves

Conversation

@schindlershadow

@schindlershadow schindlershadow commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

The setup wizard took a Dissidia 012 image as the Dissidia 1 disc. Its only check was for obj/p_fiv100.objx, which 012 has too, so the install failed later with a misleading "differs from the one the patches were made from". The undub pick had no check at all.

Now each picked file is checked as soon as it is chosen. It works for ISO and CSO files, and for Android's fd:N.

  • Dissidia 1: PSP_GAME/PARAM.SFO DISC_ID must be ULUS10437. A 012 image, another D1 release, or another game is refused, and the message says what it is.
  • Undub: it must be Dissidia 012 and must not have the English voices. The undub has the same DISC_ID as the retail US disc, so Bartz's battle voice bank is compared with the EU/US English one (size 302368 and CRC-32 6EE2B876). An image with no voice index to compare is not refused.
  • After a refusal: a WRONG DISC page appears, and its OK goes back to choosing that file. The undub pick page now says what is refused.
  • Command line: tools/d1_moves.py install also refuses a DISC_ID other than ULUS10437.
  • Docs: docs/installer.md describes the checks.

Tested

  • test_setup_install builds small ISO and CSO images in the test.
  • SETUP_TEST_DISCS runs the checks on real images:
    • D1 USA is accepted.
    • US and EU 012 are refused as D1 and as undub.
    • The US undub is accepted as undub and refused as D1.
  • The fd:N path was tried on real images.
  • d1_moves.py install refuses 012 and still installs from the right disc.
  • The wizard builds; its screenshot set includes the refusal page.

Not tested

  • Clicking through the wizard by hand.
  • The Japanese 012 release: I had no image, and it is not refused.

Also: on a failed install, the NOT FINISHED page has Open setup.log and Show setup.log in its folder. These are desktop only: Windows Explorer opens with the file selected, macOS uses Finder, and Linux opens the folder with xdg-open. If the log can't be opened, a message gives its path. Only the screenshot of the page was checked. Neither row was clicked on Windows.

Also: fix for Windows installs of the D1 moves. Python on Windows writes text files in cp1252. The D1 help texts contain characters cp1252 doesn't have, so d1_moves.py crashed halfway through writing extra_abilities.json. Every "Try again" then failed on the truncated file (seen in a user's setup.log with v0.1.18).

  • All text files these tools open are now UTF-8.
  • The file is written to a temp file and swapped in, and a broken one is kept as .bad and written again.

This was checked with Python's default-encoding warnings turned into errors, starting from a truncated file. The install went through.

Release notes

  • Setup now checks that the Dissidia 1 disc and the undub disc are the right games when you pick them, and says what is wrong. Before, a Dissidia 012 image was taken as the Dissidia 1 disc and the install failed later.
  • Windows: adding Bartz's Dissidia 1 moves no longer stops with an error. A "Try again" after that error now works too.
  • When an install fails, setup offers buttons to open its log file (setup.log) or show it in its folder.

🤖 Generated with Claude Code

schindlershadow and others added 2 commits November 18, 2026 20:42
…game

The Dissidia 1 pick only looked for obj/p_fiv100.objx, which Dissidia 012 has too, so a 012 image was taken and the
install failed later with a misleading message. Now, as soon as a file is picked (ISO or CSO, also an Android fd:N):
- Dissidia 1: PARAM.SFO DISC_ID must be ULUS10437; a 012 image, another D1 release or another game is refused
  with what it is.
- Undub: must be Dissidia 012 and must not have the English voices (Bartz's battle bank compared with the EU / US
  English one: size + CRC-32).
A refused pick shows a WRONG DISC page whose OK goes back to choosing that file. d1_moves.py install checks the
DISC_ID too. Tests: synthetic ISO / CSO images, SETUP_TEST_DISCS for real ones (D1 USA, 012 USA/EU, undub checked).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Two rows on the NOT FINISHED page when the run has a setup.log (desktop only): Open setup.log (default program) and
Show setup.log in its folder (Windows Explorer /select, macOS Finder -R, Linux xdg-open on the folder). If it cannot
be opened, a message gives the path. setup::open_on_desktop in install.cpp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schindlershadow schindlershadow changed the title Installer: check the picked Dissidia 1 and undub discs are the right game Installer: check the picked Dissidia 1 / undub discs; open setup.log from the failure page Nov 19, 2026
schindlershadow and others added 2 commits November 18, 2026 21:08
…52), and every retry then failed on the cut file

Python's text files default to the ANSI code page on Windows; the D1 help texts have characters cp1252 does not have,
so json.dump stopped half way and left a truncated extra_abilities.json; Try again failed on reading it.
- d1_moves.py, netpack.py, roster_mainbin.py (+ charmod_objx, voice_bank, package_extract): UTF-8 for every text file
- extra_abilities.json is written to .tmp and swapped in; one that does not parse is kept as .bad and written again
- the wizard runs its Python steps with PYTHONUTF8=1
Checked with PYTHONWARNDEFAULTENCODING=1 PYTHONWARNINGS=error::EncodingWarning and a truncated file: installs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on has a ._pth file (isolated mode), which ignores PYTHON* variables; the tools' explicit UTF-8 is the fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schindlershadow
schindlershadow merged commit 2a1e6ca into main Nov 19, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant