Repository navigation
battle_test: recorded walk by default, slow menu walk off unless asked for - #74
Merged
Merged
Conversation
…d for run, compare, actions and scan now replay the recorded walk (--direct, tests/replays/quick_battle_walk.txt, ~30 s to the fight) unless --menu-walk is given. walk_menus (~100 s, picture by picture) raises unless BT_MENU_WALK=1, so deck_battle.py, combo_timing.py and android_battle.py without --direct say why instead of taking the slow path. A --stage other than 12 with the default walk prints a note. Also: a run with --shots and no --script never saw the fight start (the runtime's test driver only runs with PSPRECOMP_TEST_SCRIPT set, so "[TEST] battle started" was never logged); it now gets an empty script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
battle_test.py
run,compare,actionsandscannow reach the fight with the recorded pad walk (--direct, ~30 s) by default. The picture-by-picture menu walk (~100 s) raises unless--menu-walk/BT_MENU_WALK=1is given (recording a walk for another character or stage, a runtime without direct_battle.cpp, tools with no--directyet). Also fixesrun --shotswith no--script: the test driver only runs with a script, so the fight's start was never seen; such runs now get an idle script.Tested on the desktop: a plain
battle_test.py run --shots 2reaches the fight in 29 s and saves its screenshot.Release notes
🤖 Generated with Claude Code