fix(proposal): move the spacing onto the layout boundary and make the type fluid - #34
Merged
Merged
Conversation
… type fluid The 34rem block toggled type scale and spacing while declaring nothing structural, so a reader between 545 and 599 received a measure set for a layout they did not have. I caused that. #29 lifted `.hero{grid-template-columns}` out of the 34rem block into its own 37.5rem block to fix a horizontal overflow, which left the old boundary purely typographic. Before #29 that block did declare layout. Rather than give the old boundary a structural rule it does not need, the spacing moves to 37.5rem where the hero actually restructures, and the two stepped type sizes become `clamp()` so there is no step to misplace. That is the shape `runbook` and `changelog` already use: one breakpoint, fluid type. media blocks 2 -> 1 structural decls in it 1 font-size in any block 0 step at 540..550 none remaining boundary 600->601, +541, and it restructures 390 2,687 -> 2,687 unchanged 768 1,995 -> 1,987 8px better 1,440 2,060 -> 2,060 unchanged overflow 0 across 992 widths (320-700 step 1, 700-1920 step 2), innerWidth asserted before every recorded measurement Nothing removed, no line-height touched. Co-Authored-By: CRHQ <noreply@crhq.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boundary, and I caused it
proposal's34remblock toggled type scale and spacing while declaring nothing structural — a reader between 545 and 599 received a measure set for a layout they did not have.That was #29. It lifted
.hero{grid-template-columns}out of the34remblock into its own37.5remblock to fix a horizontal overflow, and left the old boundary purely typographic. Verified against history:The fix
Rather than give the old boundary a structural rule it does not need:
37.5rem, where the hero actually restructures — type, spacing and layout now move together, which is what the correctly-classified boundaries already do;clamp()—.mast .leadand.move h2— so there is no step to misplace.That is the shape
runbookandchangelogalready use: one breakpoint, fluid type.Verification
window.innerWidthis asserted before every recorded measurement; the harness refuses rather than records on mismatch.Nothing removed. No
line-heighttouched.pnpm checkclean;pnpm exec vitest run— 151 files, 1,096 tests, all passing.A note on the test run
My first full suite showed 3 failures against a baseline of 2, and I nearly reported that my change added one. The named test passes in isolation three times in both trees, and a second full run of the fix tree is completely green — 0 failures. Both earlier runs were flake. I had compared two single samples of a non-deterministic measurement and read the difference as signal.
🤖 Generated with Claude Code