fix(launch-announcement): make spacing fluid so it does not step where the layout holds - #33
Merged
Merged
Conversation
…e the layout holds The `@media (min-width: 48rem)` block declared only spacing — `padding-inline` on `.wrap`, `padding-block` on `section` and `.hero` — and nothing structural. A reader at 768px therefore received a measure set for a layout they did not have: `section` padding jumped 0.62rem to 2.6rem, a 4x step, while the grid was identical either side. Height stepped 377px across a single pixel of width. The three values are now `clamp()`, matching the fluid `font-size` idiom already used elsewhere in this template. The ramp is anchored so that 390px clamps to the original floor and 768px reaches the original ceiling exactly, so both sampled widths are byte-for-byte unchanged in output and only the band between them — the band that carried the defect — is affected. The spacing-only breakpoint is removed; the three remaining boundaries all declare layout. Nothing was deleted, no line-height was compressed, no structural element removed. heights 390: 2838 -> 2838 768: 2601 -> 2601 1440: 2128 -> 2128 boundary 767->768 step 377px -> 1px overflow 0 at all 201 widths sampled from 320 to 1920 Co-Authored-By: CRHQ <noreply@crhq.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
@media (min-width: 48rem)declared only spacing —padding-inlineon.wrap,padding-blockonsectionand.hero— and nothing structural. A reader at 768px received a measure set for a layout they did not have:sectionpadding jumped0.62rem → 2.6rem(4×) while the grid was identical either side.The fix
Route 1 of the two offered — make the change fluid, matching the
clamp()font-sizeidiom this template already uses in three places.The ramp is anchored at 392px so 390 clamps to the original floor and 768 reaches the original ceiling exactly. Both sampled widths are unchanged in output; only the band between them — the band that carried the defect — is affected. The spacing-only breakpoint is removed.
Verification
Viewport was read back via
window.innerWidthbefore every recorded measurement; the run refuses on mismatch.Not done
Nothing deleted, no
line-heightcompressed, no structural element removed.🤖 Generated with Claude Code