fix(templates): start the spacing compaction where the layout changes - #32
Merged
Conversation
Three templates change height by hundreds of pixels across one pixel of viewport. The compaction ended at 30/34rem and the wider layout did not begin until 44/62rem, so between the two the document ran full desktop spacing inside a still-narrow single column. report 3,337 @481 -> 2,780 @481 research-brief 3,286 @552 -> 2,622 @545 postmortem 2,958 @545 -> 2,464 @545 A cliff is a layout defect at any cap, which is why this is separated from the height work held against the 2,900 re-derivation. No spacing value changes. The existing compaction block is split: the spacing half now starts at the width where the layout actually becomes one column, the type half stays where the measure needs it. Moved declarations are appended at the end of the target block so they still win where they already won -- placing them at the start silently handed three selectors to a later rule and cost postmortem 40px at 320 before it was caught. Rendered content is byte-identical to main for all seven templates. Every change here is CSS, no prose was removed to pay for it, and no gutter or spacing work is bought against the sub-390 band -- that stays frozen, and these three still peak above the cap at 320 as a result. That is the part that genuinely depends on the number. Co-Authored-By: CRHQ <noreply@crhq.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cliff is a layout defect at any cap
Three templates change height by hundreds of pixels across one pixel of viewport. The compaction ended at 30/34rem and the wider layout did not begin until 44/62rem — between the two, the document ran full desktop spacing inside a still-narrow single column.
report@481research-brief@552postmortem@545This does not depend on the threshold, which is why it is split out of #30.
No spacing value changes
The existing compaction block is split: the spacing half now starts at the width where the layout actually becomes one column; the type half stays where the measure needs it. Same declarations, earlier start.
One thing worth reading in the diff
Moved declarations are appended at the end of the target block, not the start. Placing them at the start silently handed three selectors to a later rule in the same block and cost
postmortem40px at 320 — a fix that made a width worse while the headline number improved. Caught by sweeping rather than by reading, and bydupselscanflagging the dead declarations the move created.Scope
mainfor all seven templates. Every change is CSS.dupselscanclean across all 19 templates.🤖 Generated with Claude Code