fix(meeting-recap): keep the document under budget at every width, not three - #28
Merged
Merged
Conversation
…t three The contract sampled 390, 768 and 1440. All three sit inside a compact layout, so two over-budget bands went unmeasured: 320-372 (peak 3,385px) and 545-615 (peak 3,174px), the second caused by the card collapse ending at 34rem while the table still renders tall until ~640. Move the collapse breakpoint to 40rem so the action table stays in card form until it has the width to render compactly, and add a 24rem band that spends width and vertical rhythm at the narrowest sizes: the decision numeral gutter is dropped so the text gets the full measure, and the collapsed table rows -- seven identical cards, the largest spacing lever in the document -- lose padding. Nothing structural is removed. The only type change is the h1 at <=24rem, from a 1.75rem clamp floor to 1.5rem, which is still far above every floor in the contract. Swept 320-700 at step 1 and 700-1920 at step 2, asserting innerWidth before each measurement: peak 3,385px @ 320 -> 2,820px @ 320 390 2,821 -> 2,774 768 2,082 -> 2,082 (unchanged) 1,440 1,866 -> 1,866 (unchanged) over 2,900 -> none at any width overflow-x -> 0 at every width Co-Authored-By: CRHQ <noreply@crhq.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
meeting-recapexceeded the 3,000px fail line at widths the contract never sampled.The contract samples 390, 768 and 1440 — and all three sit inside a compact layout. 390 is inside the card collapse, 768 is past the wide breakpoint, and nobody looked at the band between. The 545-615 band is the collapse ending at
34rem(544px) while the action table still renders tall until ~640.The fix
34rem->40remso the action table stays in card form until it has the width to render a table compactly. That closes 545-615.24remband for 320-384, which was over budget even with the collapse on, because every line wraps more. It spends width and vertical rhythm, never content: the decision numeral gutter is dropped so the text gets the full measure, and the seven collapsed table rows — every one paying the same padding — lose spacing.The only type change is the
h1at<=24rem, from its1.75remclamp floor to1.5rem(24px), still far above every floor in the contract (13px prose / 12px metadata / 11px labels). Nothing structural is removed.Verification — a sweep, not three samples
Stepped the width and asserted
window.innerWidthbefore each measurement; the harness refuses rather than records if the viewport does not read back.The two sampled widths that were already compliant did not move.
Other contract checks
One note on the diff
Four of my own rules in the new narrow band were larger than the corresponding rule in the wider band — the narrow band adding space back at the width with the least margin. Reading the diff found three; a check asserting narrow <= wide for every shared property found the fourth (
.tags{margin-top}). That check reports 0 inversions, 0 duplicate declarations on the committed file.🤖 Generated with Claude Code