scx_forge_agent: Generalize tracing events and switch to perf#3671
Merged
Conversation
scx_forge_agent currently depends on trace-cmd for the optional tracing summary that is passed back to the planner. That limits the signal to tracepoints and keeps the summarizer tied to the default sched events. Switch the recorder to perf so the configured [tracing].trace_events entries are passed to perf record -e. This lets runs include both tracepoints and PMU events such as cache-references or cache-misses. Use perf script with a narrow field set to build the compact model-facing summary. Make the summary generic over the events that were actually observed instead of emitting sched-specific fields. The verdict now reports observed event counts, retained-window sample rates, and a compact CPU activity summary. For PMU events, document that the counts are perf sample records rather than raw hardware counter totals. Signed-off-by: Andrea Righi <arighi@nvidia.com>
arighi
requested review from
RitzDaCat,
hodgesds,
likewhatevs,
multics69 and
sirlucjan
sirlucjan
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scx_forge_agent currently depends on trace-cmd for the optional tracing summary that is passed back to the planner. That limits the signal to tracepoints and keeps the summarizer tied to the default sched events.
Switch the recorder to perf so the configured [tracing].trace_events entries are passed to perf record -e. This lets runs include both tracepoints and PMU events such as cache-references or cache-misses. Use perf script with a narrow field set to build the compact model-facing summary.
Make the summary generic over the events that were actually observed instead of emitting sched-specific fields. The verdict now reports observed event counts, retained-window sample rates, and a compact CPU activity summary. For PMU events, document that the counts are perf sample records rather than raw hardware counter totals.