Repository navigation
Normalize action journal deadlines - #949
Merged
Merged
Conversation
Accept UTC DateTime and DateTimeOffset deadlines at the shared journal boundary while rejecting null, non-UTC, and expired values before publication. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize action-journal deadlines at the shared state boundary so the bounded action runner can pass the actual UTC
DateTimereturned byGet-CapLeaseWindowwithout dereferencing a nonexistent property.Changes
DateTimeandDateTimeOffsetvalues inNew-CapJournalStateDateTime, foreign types, and already-expired deadlines before publicationTest plan
RED: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -JournalContractOnly -ScratchRoot D:\gcr\deadline-red-49690c92 -PrebuiltFixtureManifest D:\gcr\deadline-red-fixture-6f57302b\fixtures.json -PrebuiltFixtureManifestSha256 E79D3C78A15F461359F1B12A6B3E6D1458C1FC5CD0BFC42AC53FAD86159FF1DB -> 9/10 passed; DateTimeOffset could not bind to DeadlineUtc
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -JournalContractOnly -ScratchRoot D:\gcr\deadline-green2-73c5005e -PrebuiltFixtureManifest D:\gcr\deadline-green2-fixture-6596ab56\fixtures.json -PrebuiltFixtureManifestSha256 4EE7569C6A7515E56DCED7342206A59350627351CB22D2D5223FB9687F43FD42 -> 10/10 passed with UTC and fail-closed deadline cases
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -RequireRealSeed -RealSeedZmxPath C:\gca-providers\zmx\zig-out\bin\zmx.exe -RealSeedZmxSha256 447B8E94FE5A72D0B7D0F8C614BBEFDE597DFB864FD38278DB53AE98A921EC0B -ScratchRoot D:\gcr\deadline-real185-5aeae8a9 -PrebuiltFixtureManifest D:\gcr\deadline-green2-fixture-6596ab56\fixtures.json -PrebuiltFixtureManifestSha256 4EE7569C6A7515E56DCED7342206A59350627351CB22D2D5223FB9687F43FD42 -> 185/185 passed with zero failures and zero skips
pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1-> PASS; nested UiCaptureDriver 182/182pwsh -NoProfile -File Tools\windows\Tests\Hardening.Tests.ps1-> repeated deterministic hardening 3/3 passedgit diff --checkandgit ls-files --eol-> passed; all touched files are LFChecklist
git commit -s) per the DCOmake test)make check)