Repository navigation
Fix bounded action process journaling - #948
Merged
Merged
Conversation
Give action-only launchers a dedicated numbered journal and preserve exact qualified topologies for the final bounded parity actions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the action-only launcher gate so every contained GraphCode/zmx target is released only after an immutable numbered journal publication binds its held launcher generation and job. Add the final bounded W1-W6 action path using sealed qualified layouts instead of replaying already-qualified setup actions.
Changes
Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot D:\gcr\red-full-90b49aa1 -PrebuiltFixtureManifest D:\gcr\fixture-42d65e80\fixtures.json -PrebuiltFixtureManifestSha256 0F04B1026244B31E574659A4493D84249C8ECD8F13378516E9F6858EDC22453F -> 177/182 passed; null action journal was rejected by parameter binding and action publication wiring was absent
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot D:\gcr\green2-full-192bdcd1 -PrebuiltFixtureManifest D:\gcr\green2-fixture-8dc89b9f\fixtures.json -PrebuiltFixtureManifestSha256 449C8DFD52D75C5B69A66A9FFBAD9F56D9341743196480B05CB0919B187DB20D -> 182/182 passed with zero failures and zero skips
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -RequireRealSeed -RealSeedZmxPath C:\gca-providers\zmx\zig-out\bin\zmx.exe -RealSeedZmxSha256 447B8E94FE5A72D0B7D0F8C614BBEFDE597DFB864FD38278DB53AE98A921EC0B -ScratchRoot D:\gcr\real185-35d677ab -PrebuiltFixtureManifest D:\gcr\green2-fixture-8dc89b9f\fixtures.json -PrebuiltFixtureManifestSha256 449C8DFD52D75C5B69A66A9FFBAD9F56D9341743196480B05CB0919B187DB20D -> 185/185 passed with zero failures and zero skips
pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1-> PASS; nested UiCaptureDriver 182/182pwsh -NoProfile -File Tools\windows\Tests\Hardening.Tests.ps1-> repeated deterministic hardening 3/3 passedgit diff --checkandgit ls-files --eol-> passed; all touched tracked files are LFChecklist
git commit -s) per the DCOmake test)make check)