Drop account name asumptions in rebudget and avail_ext#13
Open
hydrogs wants to merge 3 commits intoscauligi:masterfrom
Open
Drop account name asumptions in rebudget and avail_ext#13hydrogs wants to merge 3 commits intoscauligi:masterfrom
hydrogs wants to merge 3 commits intoscauligi:masterfrom
Conversation
Now is_account_account does not assume the root name of the accounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dropped the asumptions of account names in the plugin rebudget and the extension avail_ext. They now accept any root name.
As the
refried.is_account_account()function needed to be modified, I also modified the plugin clearing in order not to break it. Although I didn't modify the clearing extensions (accts_ext & journal_ext). I do not know yet how to adapt the queries.